[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-01-21 Thread cron2 (Code Review)
Attention is currently required from: d12fk, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/840?usp=email ) Change subject: dns: don't publish env vars to non-dns scripts .. Patch

[Openvpn-devel] [PATCH v1] Remove comparing username to NULL in tls_lock_username

2025-01-21 Thread Frank Lichtenheld
From: Arne Schwabe tls_lock_username is only called in a single place and that place calls this is function with up->username, which is always defined. Change-Id: Ib8adf7b31cae02e2de3d45da23b76a2d79f13e20 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on

[Openvpn-devel] [PATCH v10] mudp.c: keep offset value when resetting buffer

2025-01-21 Thread Frank Lichtenheld
From: Lev Stipakov dco-win requires control packets to be prepended with sockaddr. For that, an offset value in buffer must be kept. Doing it always doesn't harm and makes code cleaner compared to adding "if (dco_win_server)" condition. Change-Id: I145573555aaace5e94774b5f977d032d3747ed72 Signed

[Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when resetting buffer

2025-01-21 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/814?usp=email ) Change subject: mudp.c: keep offset value when resetting buffer ..

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update().

2025-01-21 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/809?usp=email ) Change subject: PUSH_UPDATE: Added remove_option() and do_update().

[Openvpn-devel] [XS] Change in openvpn[master]: Remove comparing username to NULL in tls_lock_username

2025-01-21 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/871?usp=email ) Change subject: Remove comparing username to NULL in tls_lock_username ..

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update().

2025-01-21 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, mrbff, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/809?usp=email to look at the new patch set (#12). Change subject: PUSH_UPDATE: Added remove_op

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added update_option() function.

2025-01-21 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/810?usp=email to look at the new patch set (#12). Change subject: PUSH_UPDATE: Added update_option() functio

[Openvpn-devel] [M] Change in openvpn[master]: Print warnings/errors when numerical parameters cannot be parsed

2025-01-21 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/873?usp=email ) Change subject: Print warnings/errors when numerical parameters cannot be parsed .

[Openvpn-devel] [M] Change in openvpn[master]: Print warnings/errors when numerical parameters cannot be parsed

2025-01-21 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/873?usp=email ) Change subject: Print warnings/errors when numerical parameters cannot be parsed .

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update().

2025-01-21 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, mrbff, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/809?usp=email ) Change subject: PUSH_UPDATE: Added remove_option() and do_update().

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update().

2025-01-21 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/809?usp=email ) Change subject: PUSH_UPDATE: Added remove_option() and do_update().

[Openvpn-devel] [M] Change in openvpn[master]: Print warnings/errors when numerical parameters cannot be parsed

2025-01-21 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/873?usp=email to look at the new patch set (#2). Change subject: Print warnings/errors when numerical parameters cannot be parsed ...

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-01-21 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/840?usp=email ) Change subject: dns: don't publish env vars to non-dns scripts ..

[Openvpn-devel] [M] Change in openvpn[master]: Print warnings/errors when numerical parameters cannot be parsed

2025-01-21 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/873?usp=email ) Change subject: Print warnings/errors when numerical parameters cannot be parsed .

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update().

2025-01-21 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, mrbff, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/809?usp=email ) Change subject: PUSH_UPDATE: Added remove_option() and do_update().

[Openvpn-devel] [M] Change in openvpn[master]: Print warnings/errors when numerical parameters cannot be parsed

2025-01-21 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/873?usp=email to review the following change. Change subject: Print warnings/errors when numerical parameters cannot be parsed .

[Openvpn-devel] [M] Change in openvpn[master]: Implement override-username

2025-01-21 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/872?usp=email to look at the new patch set (#4). Change subject: Implement override-username

[Openvpn-devel] [M] Change in openvpn[master]: Implement override-username

2025-01-21 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/872?usp=email to look at the new patch set (#3). Change subject: Implement override-username

[Openvpn-devel] [M] Change in openvpn[master]: Implement override-username

2025-01-21 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email ) Change subject: Implement override-username .. Patch Set 2: (1 comment)