Re: [Openvpn-devel] RFC: tchar removal patch series

2025-01-08 Thread Gert Doering
Hi, On Wed, Jan 08, 2025 at 03:52:12PM -0500, Selva Nair wrote: > I think the use of tchar is outdated and I'm all for purging it. This is good :-) - would you have time to look at the commits in gerrit? gert -- "If was one thing all people took for granted, was conviction that if you feed ho

Re: [Openvpn-devel] RFC: tchar removal patch series

2025-01-08 Thread Selva Nair
Hi, I think the use of tchar is outdated and I'm all for purging it. best, Selva On Wed, Jan 8, 2025 at 8:57 AM Frank Lichtenheld wrote: > Hi. > > Today I submitted a patch series that removes all usages of > tchar.h from the OpenVPN 2 code base. You can see the full > series here: https://ge

[Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files

2025-01-08 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config files

[Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files

2025-01-08 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/436?usp=email ) Change subject: allow user to specify 'local' multiple times in config files

Re: [Openvpn-devel] [PATCH 1/1] console_systemd: remove the timeout when using `systemd-ask-password`

2025-01-08 Thread Ben Boeckel via Openvpn-devel
On Wed, Jan 08, 2025 at 15:59:42 +0100, David Sommerseth wrote: > Given that the oldest Linux distro with systemd which supports the > --timeout argument in systemd-ask-password, this can get my ACK. Thanks. I thought to look at when it was introduced. It has been there (manpage documentation was

Re: [Openvpn-devel] [PATCH 1/1] console_systemd: remove the timeout when using `systemd-ask-password`

2025-01-08 Thread David Sommerseth via Openvpn-devel
On 31/12/2024 21:46, Ben Boeckel via Openvpn-devel wrote: Without this, the password request will expire after 90 seconds leaving no way to provide the password without OpenVPN asking for it again. Given that interactive use will wait for input without a timeout, it makes sense to have non-intera

[Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null

2025-01-08 Thread flichtenheld (Code Review)
Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/811?usp=email ) Change subject: Add lwip support to t_server_null .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null

2025-01-08 Thread flichtenheld (Code Review)
Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/811?usp=email ) Change subject: Add lwip support to t_server_null .. Patch Set

[Openvpn-devel] RFC: tchar removal patch series

2025-01-08 Thread Frank Lichtenheld
Hi. Today I submitted a patch series that removes all usages of tchar.h from the OpenVPN 2 code base. You can see the full series here: https://gerrit.openvpn.net/q/topic:%22tchar-removal%22 This series came about when I looked into the Windows code for a potential clang-format reformat and for r

[Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null

2025-01-08 Thread mattock (Code Review)
Attention is currently required from: flichtenheld, plaisthos. mattock has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/811?usp=email ) Change subject: Add lwip support to t_server_null .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: Post tchar.h removal cleanup

2025-01-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/854?usp=email to look at the new patch set (#2). Change subject: Post tchar.h removal cleanup ..

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/text-removal.sh: Script to remove usage of tchar.h

2025-01-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/852?usp=email to review the following change. Change subject: dev-tools/text-removal.sh: Script to remove usage of tchar.h ...

[Openvpn-devel] [S] Change in openvpn[master]: openvpnserv: Fix some inconsistent usages of TEXT()

2025-01-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/851?usp=email to review the following change. Change subject: openvpnserv: Fix some inconsistent usages of TEXT()

[Openvpn-devel] [S] Change in openvpn[master]: Post tchar.h removal cleanup

2025-01-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/854?usp=email to review the following change. Change subject: Post tchar.h removal cleanup ...

[Openvpn-devel] [XL] Change in openvpn[master]: Add support for HAProxy's PROXY protocol

2025-01-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, ralf_lici. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/685?usp=email ) Change subject: Add support for HAProxy's PROXY protocol .. P

[Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update().

2025-01-08 Thread mrbff (Code Review)
Attention is currently required from: flichtenheld, mrbff, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/809?usp=email to look at the new patch set (#10). Change subject: PUSH_UPDATE: Added remove_op