[Openvpn-devel] [PATCH 0/1] Remove system password timeout

2024-12-31 Thread Ben Boeckel via Openvpn-devel
PR: https://github.com/OpenVPN/openvpn/pull/649 Thanks, --Ben Ben Boeckel (1): console_systemd: remove the timeout when using `systemd-ask-password` src/openvpn/console_systemd.c | 1 + 1 file changed, 1 insertion(+) base-commit: cb878882388bfe9dc49b116190c5c6ae8918322d -- 2.47.1 _

[Openvpn-devel] [PATCH 1/1] console_systemd: remove the timeout when using `systemd-ask-password`

2024-12-31 Thread Ben Boeckel via Openvpn-devel
Without this, the password request will expire after 90 seconds leaving no way to provide the password without OpenVPN asking for it again. Given that interactive use will wait for input without a timeout, it makes sense to have non-interactive usage also wait until the user is ready instead of for

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-31 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [L] Change in openvpn[master]: Allow DEFAULT in data-ciphers and report both expanded and user set o...

2024-12-31 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/828?usp=email ) Change subject: Allow DEFAULT in data-ciphers and report both expanded and user set option .. Allow DEFAULT in data-ciphers and report bot

[Openvpn-devel] [L] Change in openvpn[master]: Allow DEFAULT in data-ciphers and report both expanded and user set o...

2024-12-31 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/828?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Allow DEFAULT in data-ciphers and report both expan

[Openvpn-devel] [PATCH applied] Re: Allow DEFAULT in data-ciphers and report both expanded and user set option

2024-12-31 Thread Gert Doering
I have only lightly reviewed this, and it all seems to make sense. The idea is good, as we have seen in all these bug reports for 2.6 related to `--data-ciphers`. The test rig is happy. Also, unit tests ;-) Your patch has been applied to the master branch. commit 6a7931a4a89cb35be7b799942e7fa0

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: simplify do_close_link_socket()

2024-12-31 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#8) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/813?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco-win: simplify do_close_link_socket() .

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: simplify do_close_link_socket()

2024-12-31 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/813?usp=email ) Change subject: dco-win: simplify do_close_link_socket() .. dco-win: simplify do_close_link_socket() c->c2.link_socket_owned is true in cl

[Openvpn-devel] [PATCH applied] Re: dco-win: simplify do_close_link_socket()

2024-12-31 Thread Gert Doering
Looks reasonable, does the same thing with less lines of code, adjusted to multisocket. Test compiled on ubuntu/mingw. Your patch has been applied to the master branch. commit 1452625bc364cb5847daedaad238c7a5eb3eff5e Author: Lev Stipakov Date: Tue Dec 31 15:54:17 2024 +0100 dco-win: simp

[Openvpn-devel] [PATCH v7] dco-win: simplify do_close_link_socket()

2024-12-31 Thread Gert Doering
From: Lev Stipakov c->c2.link_socket_owned is true in client mode and for the global context in the server mode - those are exactly the cases when we want to set sd to undefined when using dco-win. Change-Id: I3232dd8d855ca3f198b4ca3b2ef4f67cec49f3d4 Signed-off-by: Lev Stipakov Acked-by: Gert D

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: simplify do_close_link_socket()

2024-12-31 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/813?usp=email ) Change subject: dco-win: simplify do_close_link_socket() ..

[Openvpn-devel] [S] Change in openvpn[master]: dco-win: simplify do_close_link_socket()

2024-12-31 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/813?usp=email to look at the new patch set (#7). The following approvals got outdated an

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-31 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .