[Openvpn-devel] [XS] Change in openvpn[master]: dns: store IPv4 addresses in network byte order

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/834?usp=email to review the following change. Change subject: dns: store IPv4 addresses in network byte order

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to review the following change. Change subject: dns: apply settings via script on unixoid system

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email to look at the new patch set (#3). Change subject: dns: support multiple domains withou

[Openvpn-devel] [M] Change in openvpn[master]: dns: support running up/down script with privsep

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to review the following change. Change subject: dns: support running up/down script with privsep

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email to review the following change. Change subject: dns: don't publish env vars to non-dns scripts .

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to look at the new patch set (#3). The change is no longer submittable: checks~Ch

[Openvpn-devel] [S] Change in openvpn[master]: service: add utf8to16 function that takes a size

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/836?usp=email to review the following change. Change subject: service: add utf8to16 function that takes a size

[Openvpn-devel] [S] Change in openvpn[master]: dns: clone options via pointer instead of copy

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/835?usp=email to review the following change. Change subject: dns: clone options via pointer instead of copy .

[Openvpn-devel] [M] Change in openvpn[master]: Trigger renegotiation of data key if getting close to the AEAD usage ...

Attention is currently required from: MaxF, cron2, flichtenheld, plaisthos. syzzer has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/796?usp=email ) Change subject: Trigger renegotiation of data key if getting close to the AEAD usage limit .

[Openvpn-devel] [M] Change in openvpn[master]: Use XOR instead of concatenation for calculation of IV from implicit IV

Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. syzzer has removed a vote from this change. ( http://gerrit.openvpn.net/c/openvpn/+/797?usp=email ) Change subject: Use XOR instead of concatenation for calculation of IV from implicit IV

[Openvpn-devel] [M] Change in openvpn[master]: Use XOR instead of concatenation for calculation of IV from implicit IV

Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. syzzer has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/797?usp=email ) Change subject: Use XOR instead of concatenation for calculation of IV from implicit IV ..

[Openvpn-devel] [S] Change in openvpn[master]: forward: Fix potential unaligned access in drop_if_recursive_routing

cron2 has uploaded a new patch set (#4) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/827?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: forward: Fix potential unaligned access in drop_if_rec

[Openvpn-devel] [S] Change in openvpn[master]: forward: Fix potential unaligned access in drop_if_recursive_routing

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/827?usp=email ) Change subject: forward: Fix potential unaligned access in drop_if_recursive_routing .. forward: Fix potential unaligned access in drop_if

[Openvpn-devel] [PATCH applied] Re: forward: Fix potential unaligned access in drop_if_recursive_routing

Thanks for that. We had quite a discussion on IRC on why this is needed and whether it's a bug in clang - turns out it is not, the linux implementation of IN6_ARE_ADDR_EQUAL() uses 4x 32bit compare, which is sensitive to alignment, while all the rest of the world uses memcmp() which does not care

[Openvpn-devel] [PATCH v3] forward: Fix potential unaligned access in drop_if_recursive_routing

From: Frank Lichtenheld ASAN error: forward.c:1433:13: runtime error: member access within misaligned address 0x51e2f52e for type 'const struct in6_addr', which requires 4 byte alignment v2: Use memcmp instead of memcpy Change-Id: I74a9eec4954f3f9d208792b6b34357571f76ae4c Signed-off-by: Fra

[Openvpn-devel] [S] Change in openvpn[master]: forward: Fix potential unaligned access in drop_if_recursive_routing

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/827?usp=email ) Change subject: forward: Fix potential unaligned access in drop_if_recursive_routing .

[Openvpn-devel] [S] Change in openvpn[master]: forward: Fix potential unaligned access in drop_if_recursive_routing

Attention is currently required from: cron2, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/827?usp=email to look at the new patch set (#3). Change subject: forward: Fix potential unaligned access in drop_if_recur

[Openvpn-devel] [S] Change in openvpn[master]: forward: Fix potential unaligned access in drop_if_recursive_routing

Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/827?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-

[Openvpn-devel] [S] Change in openvpn[master]: forward: Fix potential unaligned access in drop_if_recursive_routing

Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/827?usp=email ) Change subject: forward: Fix potential unaligned access in drop_if_recursive_routing .

[Openvpn-devel] [S] Change in openvpn[master]: forward: Fix potential unaligned access in drop_if_recursive_routing

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/827?usp=email ) Change subject: forward: Fix potential unaligned access in drop_if_recursive_routing .

[Openvpn-devel] [S] Change in openvpn[master]: forward: Fix potential unaligned access in drop_if_recursive_routing

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/827?usp=email ) Change subject: forward: Fix potential unaligned access in drop_if_recursive_routing .

[Openvpn-devel] IRC community meeting summary

Meeting summary for 11 December 2024: * *Reminder: no meetings on 25th of December, 1st of January* /For obvious reasons./ * *Updated: DCO Linux upstreaming* /Upstreaming DCO to Linux is proceeding, it is in review stage at the moment./ /Patchset v13 and v14 followed really fast an

[Openvpn-devel] [M] Change in openvpn[master]: Use XOR instead of concatenation for calculation of IV from implicit IV

Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/797?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Use XOR instead of concatenation for

[Openvpn-devel] [L] Change in openvpn[master]: options: Cleanup and simplify options_postprocess_verify_ce

Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/832?usp=email to look at the new patch set (#2). Change subject: options: Cleanup and simplify options_postprocess_verify_ce ...