Hi,
On Sun, Dec 08, 2024 at 12:17:05AM +0100, corubba via Openvpn-devel wrote:
> getpeername() and getsockname() will truncate the result if it is
> larger than the passed-in length. Because here always the size of the
> `sa` IPv4 union member was passed in, all larger (aka IPv6) results
> were tr
Acked-by: Gert Doering
Neither the code nor the manpage are particularily easy to digest, but
after staring at the code for quite a bit I have to agree with your
manpage fix. The "to" bit goes into the filename...
&& !getsockname(cp->sd, (struct sockaddr *) &to.addr.sa, &dlen))
..
const
I have not actually tested this (beyond "GHA run" passed) because I have
no current test setup for incoming port share with journal files - but
the code change is "obviously correct" and our picky compilers do not
object either.
Your patch has been applied to the master and release/2.6 branch (bug