[Openvpn-devel] [XS] Change in openvpn[master]: configure: Switch to C11 by default

2024-07-17 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/673?usp=email ) Change subject: configure: Switch to C11 by default .. configure: Switch to C11 by default Mostly so we can use anonymous structs without

[Openvpn-devel] [PATCH applied] Re: configure: Switch to C11 by default

2024-07-17 Thread Gert Doering
As discussed before, this breaks OpenBSD 6.8 builds (and, generally, other systems with very old compilers). Not sure the benefit of getting rid of a few hoops for anonymous unions is worth it, but then, it's not like people on those systems couldn't just update... Your patch has been applied to

[Openvpn-devel] [XS] Change in openvpn[master]: configure: Switch to C11 by default

2024-07-17 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/673?usp=email ) Change subject: configure: Switch to C11 by default .. configure: Switch to C11 b

[Openvpn-devel] [M] Change in openvpn[master]: Allow trailing \r and \n in control channel message

2024-07-17 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/672?usp=email ) Change subject: Allow trailing \r and \n in control channel message .. Allow trailing \r and \n in control channel message Writing a reaso

[Openvpn-devel] [M] Change in openvpn[master]: Allow trailing \r and \n in control channel message

2024-07-17 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#5) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/672?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Allow trailing \r and \n in control channel message

[Openvpn-devel] [PATCH applied] Re: Allow trailing \r and \n in control channel message

2024-07-17 Thread Gert Doering
Stared at code, reviewed, and fed to my test case where the server replies with "AUTH_FAIL,you stink\r\n" - which wasn't working with the previous code (and was overlooked during testing), now works. 2024-07-17 20:54:32 AUTH: Received control message: AUTH_FAILED,you stink Also, unit tests, yay :

[Openvpn-devel] [PATCH applied] Re: Allow trailing \r and \n in control channel message

2024-07-17 Thread Gert Doering
Acked-by: Gert Doering Thanks for the backport. Verified that it's the same change (without the unit test, and having extract_command_buffer() in forward.c), and that it gets the job done :-) Your patch has been applied to the release/2.5 branch. commit dddb87f126a6e87e61de830a9efe0bc257a71e2b

[Openvpn-devel] IRC community meeting summary

2024-07-17 Thread Johan Draaisma
Meeting summary for 17 July 2024: * *Updated: release openvpn 2.6.12* /This should address the slightly-too-aggressive security fix in 2.6.11 that could affect people sending custom messages with trailing newline characters./ /Should be a release tomorrow on 18 July./ * *Updated: O