Re: [Openvpn-devel] [PATCH 1/5] src/openvpn/init.c: handle strdup failures

On 08/07/2024 23:53, Илья Шипицин wrote: пн, 8 июл. 2024 г. в 23:47, Antonio Quartulli : Hi, On 08/07/2024 23:44, Илья Шипицин wrote: +msg( M_FATAL, "Failed allocate memory saved_pid_file_name"); patchset looks great, but (!!) there should be no space after the opening paren

Re: [Openvpn-devel] [PATCH 1/5] src/openvpn/init.c: handle strdup failures

пн, 8 июл. 2024 г. в 23:47, Antonio Quartulli : > > Hi, > > On 08/07/2024 23:44, Илья Шипицин wrote: > >>> +msg( M_FATAL, "Failed allocate memory > >>> saved_pid_file_name"); > >> > >> patchset looks great, but (!!) there should be no space after the > >> opening parenthesis.. > >

Re: [Openvpn-devel] [PATCH 1/5] src/openvpn/init.c: handle strdup failures

Hi, On 08/07/2024 23:44, Илья Шипицин wrote: +msg( M_FATAL, "Failed allocate memory saved_pid_file_name"); patchset looks great, but (!!) there should be no space after the opening parenthesis.. I just followed code style already present in repo $ grep -r 'msg( M_FATAL' . gr

Re: [Openvpn-devel] [PATCH 1/5] src/openvpn/init.c: handle strdup failures

пн, 8 июл. 2024 г. в 23:13, Antonio Quartulli : > > Hi, > > On 08/07/2024 23:08, Ilia Shipitsin wrote: > > Signed-off-by: Ilia Shipitsin > > --- > > src/openvpn/init.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/src/openvpn/init.c b/src/openvpn/init.c > > index a49e5639..

Re: [Openvpn-devel] [PATCH 1/5] src/openvpn/init.c: handle strdup failures

Hi, On 08/07/2024 23:08, Ilia Shipitsin wrote: Signed-off-by: Ilia Shipitsin --- src/openvpn/init.c | 4 1 file changed, 4 insertions(+) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index a49e5639..59205ba6 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -4967,6 +49

[Openvpn-devel] [PATCH 2/5] sample/sample-plugins/defer/multi-auth.c: handle strdup errors

Signed-off-by: Ilia Shipitsin --- sample/sample-plugins/defer/multi-auth.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/sample/sample-plugins/defer/multi-auth.c b/sample/sample-plugins/defer/multi-auth.c index 2c482799..109fa40c 100644 --- a/sample/sample-plugins/defer/mu

[Openvpn-devel] [PATCH 4/5] src/openvpn/ssl_verify.c: handle strdup errors

Signed-off-by: Ilia Shipitsin --- src/openvpn/ssl_verify.c | 8 1 file changed, 8 insertions(+) diff --git a/src/openvpn/ssl_verify.c b/src/openvpn/ssl_verify.c index 934ff8d8..c4b95553 100644 --- a/src/openvpn/ssl_verify.c +++ b/src/openvpn/ssl_verify.c @@ -1629,6 +1629,10 @@ verify_us

[Openvpn-devel] [PATCH 0/5] handle strdup errors

strdup might return NULL in case of failure, which is sometimes not handled Ilia Shipitsin (5): src/openvpn/init.c: handle strdup failures sample/sample-plugins/defer/multi-auth.c: handle strdup errors src/openvpn/auth_token.c: handle strdup errors src/openvpn/ssl_verify.c: handle strdup e

[Openvpn-devel] [PATCH 3/5] src/openvpn/auth_token.c: handle strdup errors

Signed-off-by: Ilia Shipitsin --- src/openvpn/auth_token.c | 8 1 file changed, 8 insertions(+) diff --git a/src/openvpn/auth_token.c b/src/openvpn/auth_token.c index 6787ea7d..2278afe6 100644 --- a/src/openvpn/auth_token.c +++ b/src/openvpn/auth_token.c @@ -260,6 +260,10 @@ generate_au

[Openvpn-devel] [PATCH 5/5] tests/unit_tests/openvpn/test_auth_token.c: handle strdup errors

Signed-off-by: Ilia Shipitsin --- tests/unit_tests/openvpn/test_auth_token.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/unit_tests/openvpn/test_auth_token.c b/tests/unit_tests/openvpn/test_auth_token.c index 3a3cb69b..8a0c16af 100644 --- a/tests/unit_tests/openvpn/test_auth_toke

[Openvpn-devel] [PATCH 1/5] src/openvpn/init.c: handle strdup failures

Signed-off-by: Ilia Shipitsin --- src/openvpn/init.c | 4 1 file changed, 4 insertions(+) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index a49e5639..59205ba6 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -4967,6 +4967,10 @@ write_pid_file(const char *filename, const

[Openvpn-devel] [S] Change in openvpn[master]: Allow trailing \r and \n in control channel message

Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/672?usp=email ) Change subject: Allow trailing \r and \n in control channel message ...

[Openvpn-devel] [S] Change in openvpn[master]: Allow trailing \r and \n in control channel message

Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/672?usp=email ) Change subject: Allow trailing \r and \n in control channel message .. P

[Openvpn-devel] [S] Change in openvpn[master]: Allow trailing \r and \n in control channel message

Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by flichtenh

[Openvpn-devel] [S] Change in openvpn[master]: Allow trailing \r and \n in control channel message

Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/672?usp=email ) Change subject: Allow trailing \r and \n in control channel message .. P

[Openvpn-devel] [S] Change in openvpn[master]: Allow trailing \r and \n in control channel message

Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/672?usp=email ) Change subject: Allow trailing \r and \n in control channel message .. P

[Openvpn-devel] [S] Change in openvpn[master]: Allow trailing \r and \n in control channel message

Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=email to review the following change. Change subject: Allow trailing \r and \n in control channel message ..