Thanks Gert. I see that our tests for the "release/2.6" branch are
passing. This was discovered by testing against the master branch so I
don't think this patch needs backporting.
Sincerely
Juliusz Sosinowicz
On 12/02/2024 18:10, Gert Doering wrote:
Thanks for this updated patch, which fixes
Thanks for this updated patch, which fixes the issue in a much nicer
way. I'm not sure if you observe the problem in release/2.6 as well
- if yes, I need a release/2.6-specific patch for that (as half the
new test drivers are not in that branch).
Quick test with an in-tree build on FreeBSD and GH
Am 12.02.24 um 14:25 schrieb Juliusz Sosinowicz:
Including "ssl.h" conflicts with the wolfSSL ssl.h header file. The openvpn/src
directory needs to be included before include/wolfssl. include/wolfssl needs to be
included so that openvpn can pick up wolfSSL compatibility headers instead of OpenS
Hi Gert,
that is the direction I went with the latest patch I sent over.
Sincerely
Juliusz Sosinowicz
On 12/02/2024 13:53, Gert Doering wrote:
Hi,
On Mon, Feb 12, 2024 at 10:57:41AM +0100, Juliusz Sosinowicz wrote:
commit 70b39f2bea9fd6e57f31e32b2041246731140cb2 has added the use of
ACK_SIZE
Including "ssl.h" conflicts with the wolfSSL ssl.h header file. The openvpn/src
directory needs to be included before include/wolfssl. include/wolfssl needs to
be included so that openvpn can pick up wolfSSL compatibility headers instead
of OpenSSL headers without changing the paths.
src/openvp
Hi,
On Mon, Feb 12, 2024 at 10:57:41AM +0100, Juliusz Sosinowicz wrote:
> commit 70b39f2bea9fd6e57f31e32b2041246731140cb2 has added the use of
> ACK_SIZE and RELIABLE_ACK_SIZE in test_ssl.c. These are defined in
> reliable.h which should be included through your ssl.h. Since our ssl.h is
> being p
Hi Arne,
commit 70b39f2bea9fd6e57f31e32b2041246731140cb2 has added the use of
ACK_SIZE and RELIABLE_ACK_SIZE in test_ssl.c. These are defined in
reliable.h which should be included through your ssl.h. Since our ssl.h
is being picked up, these never get defined and make check results in
the fo
Hi Frank,
thank you for the explanation. I did not test out-of-tree builds before
submitting the patch. I'll try to implement Gert's solution and write a
Makefile patch instead.
Sincerely
Juliusz Sosinowicz
On 09/02/2024 17:39, Frank Lichtenheld wrote:
On Fri, Feb 09, 2024 at 04:51:09PM +01
