Makes sense (I did read the GH issue).
Your patch has been applied to the master branch.
commit 53b16d07e889b69128203d3b50ed47ceb77c5771
Author: Frank Lichtenheld
Date: Thu Feb 1 13:30:39 2024 +0100
README.cmake.md: Document minimum required CMake version for --preset
Signed-off-by:
Tested locally (freebsd, autoconf) and on the GHA builds.
Your patch has been applied to the master branch.
commit bb0849db20747dc4acea394c4db807a47cbc526b
Author: Arne Schwabe
Date: Thu Feb 1 15:48:17 2024 +0100
Allow unit tests to fall back to hard coded location
Acked-by: Frank L
cron2 has uploaded a new patch set (#2) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/509?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Allow unit tests to fall back to hard coded locatio
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/509?usp=email )
Change subject: Allow unit tests to fall back to hard coded location
..
Allow unit tests to fall back to hard coded location
Settings the
From: Arne Schwabe
Settings the environment variable required for running unit tests is
tiresome in my IDE (Clion). So allow unit tests to fall back to a hard
coded location in case the environment variable is not set.
Change-Id: Ide72b81f497088dd0fd2cdcfff83cbce5b48f145
Acked-by: Frank Lichtenh
CMakePreset.json is supported since 3.19, but we have a version
3 preset file, so need at least 3.21.
Github: OpenVPN/openvpn#489
Change-Id: I44c555f6ffa08f2aee739c7f687fa3b678c86231
Signed-off-by: Frank Lichtenheld
---
README.cmake.md | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/509?usp=email )
Change subject: [CMake] Allow unit tests to fall back to hard coded location
.
