cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/504?usp=email )
Change subject: Ensure that all unit tests use unbuffered stdout and stderr
..
Ensure that all unit tests use unbuffered stdout and stderr
Tested on a local "make check" run and on GHA (another option might have
been to change our mock x_msg() to use stderr instead, but this way we
can also see "if anything else" wants to say something on stdout).
Your patch has been applied to the master branch.
commit 7869617a0f85089fb5e6fbe2db6f0
cron2 has uploaded a new patch set (#5) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/504?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Ensure that all unit tests use unbuffered stdout an
- add protocol-flag aead-packet-format-v2 This signals the client to
switch to the new data channel format.
And finally have the data channel format. Since this format is
negotiated like the cipher, there is no need to use another opcode if
keep the peer id to just 24 bit. But we might want t
From: Arne Schwabe
stderr is normally always unbuffered but stdout can be buffered. Especially,
when stdout is redirected it will become buffered while it is normally
unbuffered when connected to a terminal. This mean that if the unit exits
prematurely, the output in the buffered output will be l
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/504?usp=email )
Change subject: Ensure that all unit tests use unbuffered stdout and stderr
..
