[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2023-12-06 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email ) Change subject: Implement the --tls-export-cert feature .. Patch

Re: [Openvpn-devel] [PATCH] fix(ssl): init peer_id when init tls_multi

2023-12-06 Thread Gert Doering
Hi, On Fri, Oct 20, 2023 at 01:12:13AM +0800, yatta wrote: > From: yatta > From: pushan <62173185+pusha...@users.noreply.github.com> So, we have a patch that fixes a problem and an ACK for it, but for a proper commit I actually need something like a real name and a working mail address... Could

[Openvpn-devel] [L] Change in openvpn[master]: test_user_pass: new UT for get_user_pass

2023-12-06 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/468?usp=email ) Change subject: test_user_pass: new UT for get_user_pass .. Patch Set 1:

[Openvpn-devel] [XS] Change in openvpn[master]: unit_tests: remove includes for mock_msg.h

2023-12-06 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/467?usp=email ) Change subject: unit_tests: remove includes for mock_msg.h .. Patch Set

[Openvpn-devel] [XS] Change in openvpn[master]: unit_tests: remove includes for mock_msg.h

2023-12-06 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/467?usp=email to review the following change. Change subject: unit_tests: remove includes for mock_msg.h .

[Openvpn-devel] [L] Change in openvpn[master]: test_user_pass: new UT for get_user_pass

2023-12-06 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/468?usp=email to review the following change. Change subject: test_user_pass: new UT for get_user_pass ...

Re: [Openvpn-devel] [PATCH] fix(ssl): init peer_id when init tls_multi

2023-12-06 Thread Arne Schwabe
Am 19.10.23 um 19:12 schrieb yatta: From: pushan <62173185+pusha...@users.noreply.github.com> When openvpn run in UDP server mode, if ssl connections reach the max clients, the next connection would be failed in `multi_create_instance` and the half connection will be close in `multi_close_inst

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2023-12-06 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=email to look at the new patch set (#2). Change subject: Implement the --tls-export-cert feature ..

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2023-12-06 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email ) Change subject: Implement the --tls-export-cert feature .. Patch

[Openvpn-devel] Correction: IRC community meeting summary

2023-12-06 Thread Johan Draaisma
I had the date wrong in the previous mail. Sorry. Meeting summary for 6 December 2023: * *New: spam on forums.* /It just keeps coming. We need a solution./ /asked pippin_ if he could maybe get attention from ecrist to try and solve this./ * *Updated: Website release process woes*

[Openvpn-devel] IRC community meeting summary

2023-12-06 Thread Johan Draaisma
Meeting summary for 22 November 2023: * *New: spam on forums.* /It just keeps coming. We need a solution./ /asked pippin_ if he could maybe get attention from ecrist to try and solve this./ * *Updated: Website release process woes* /Website team continues to report that they are on

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --export-peer-cert feature

2023-12-06 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email ) Change subject: Implement the --export-peer-cert feature .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --export-peer-cert feature

2023-12-06 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=email to review the following change. Change subject: Implement the --export-peer-cert feature .

[Openvpn-devel] [PATCH applied] Re: Remove superfluous x509_write_pem()

2023-12-06 Thread Gert Doering
Acked-by: Gert Doering Does what it says on the lid. Test compiled on FreeBSD, but that brought no surprises as "git grep" confirms this function is no longer called. I could have squashed this with the previous patch, but since it hit the list as two patches, I decided to keep the direct refer

[Openvpn-devel] [PATCH applied] Re: Remove --tls-export-cert

2023-12-06 Thread Gert Doering
Acked-by: Gert Doering I have not explicitly verified that all code that was from the original author is gone now - in this, I do trust David. I *did* test that the rest still works (client, server, GHA tests). The actual code change looks fairly straightforward. I have not used the "2.6" patc