[Openvpn-devel] [M] Change in openvpn[master]: Print server temp key details

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/364?usp=email to look at the new patch set (#2). Change subject: Print server temp key details ..

[Openvpn-devel] [M] Change in openvpn[master]: Print SSL peer signature information in handshake debug details

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/365?usp=email to look at the new patch set (#2). Change subject: Print SSL peer signature information in handshake debug details

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco: warn if DATA_V1 packets are sent to userspace

2023-10-07 Thread flichtenheld (Code Review)
Attention is currently required from: stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/368?usp=email ) Change subject: dco: warn if DATA_V1 packets are sent to userspace .. Patch

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco: warn if DATA_V1 packets are sent to userspace

2023-10-07 Thread stipa (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/368?usp=email to review the following change. Change subject: dco: warn if DATA_V1 packets are sent to userspace ...

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-10-07 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/325?usp=email ) Change subject: Remove ability to use configurations without TLS by default ..

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco-win: get driver version

2023-10-07 Thread stipa (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/367?usp=email to look at the new patch set (#3). Change subject: dco-win: get driver version

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco-win: get driver version

2023-10-07 Thread stipa (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/367?usp=email to look at the new patch set (#2). Change subject: dco-win: get driver version

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco-win: get driver version

2023-10-07 Thread stipa (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/367?usp=email to review the following change. Change subject: dco-win: get driver version ..

Re: [Openvpn-devel] [PATCH] Remove openssl engine method for loading the key

2023-10-07 Thread Gert Doering
Hi, On Fri, Oct 06, 2023 at 01:19:10PM +0200, Arne Schwabe wrote: > This is a contribution for loading engine key. OpenSSL engine is > deprecated since OpenSSL 3.0 and James Bottomlehy has not agreed > to the proposed license chagne. He is also okay with removing > with the feature from the curren

[Openvpn-devel] [M] Change in openvpn[master]: Print server temp key details

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/364?usp=email to review the following change. Change subject: Print server temp key details

[Openvpn-devel] [XS] Change in openvpn[master]: Add warning for the --show-groups command that some groups are missing

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/366?usp=email to review the following change. Change subject: Add warning for the --show-groups command that some groups are missin

[Openvpn-devel] [M] Change in openvpn[master]: Print SSL peer signature information in handshake debug details

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/365?usp=email to review the following change. Change subject: Print SSL peer signature information in handshake debug details ..

[Openvpn-devel] [S] Change in openvpn[master]: Add warning if a p2p NCP client connects to a p2mp server

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/323?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-10-07 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/325?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review-1 by