[Openvpn-devel] [S] Change in openvpn[release/2.6]: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-09-23 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/312?usp=email ) Change subject: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant .. Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

[Openvpn-devel] [PATCH applied] Re: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-09-23 Thread Gert Doering
Backport of 846951665a60424b98097ad0a77ec6cb1c3d05ac (taking into account lack of HAVE_XKEY_PROVIDER tests, I think), smoke tested on GHA MSVC builds. Amazing amount of ACKs that accumulated here... Your patch has been applied to the release/2.6 branch. commit 4abdb1235833e9e3b9510ec50bd5abd150b

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-09-23 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/312?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by d12fk, Code-Review+2 by selvanair, Code-Review+2 by stipa Change subject: Mak

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: buffer: use memcpy in buf_catrunc

2023-09-23 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/314?usp=email ) Change subject: buffer: use memcpy in buf_catrunc .. buffer: use memcpy in buf_catrunc Since we use strlen() to determine the length and t

[Openvpn-devel] [PATCH applied] Re: buffer: use memcpy in buf_catrunc

2023-09-23 Thread Gert Doering
Straightforward cherrypick, smoke tested on linux. Your patch has been applied to the release/2.6 branch. commit 946219115d00c6ae658afcf538249e721e6bd600 (release/2.6) Author: Frank Lichtenheld Date: Fri Sep 22 18:04:41 2023 +0200 buffer: use memcpy in buf_catrunc Signed-off-by: Fra

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: buffer: use memcpy in buf_catrunc

2023-09-23 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/314?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by d12fk, Code-Review+2 by ordex Change subject: buffer: use memcpy in buf_catru