cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/341?usp=email )
Change subject: CMake: fix broken daemonization and syslog functionality
..
CMake: fix broken daemonization and syslog functionality
While
Your patch has been applied to the master branch.
I have not tested it further, given that it has plenty of ACKs (and
only affects cmake build system).
Two observations, though - the cmake changes look incomplete, there
is still many "#undef HAVE_something" left. Shouldn't they all be
completed
cron2 has uploaded a new patch set (#2) to the change originally created by
stipa. ( http://gerrit.openvpn.net/c/openvpn/+/341?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld, Code-Review+2 by plaisthos
Change subject: CMake: fix broken daemoniza
Attention is currently required from: cron2.
Hello cron2,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/361?usp=email
to look at the new patch set (#2).
Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to
Patchwork
Attention is currently required from: cron2.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/361?usp=email )
Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to
Patchwork
...
flichtenheld has uploaded this change for review. (
http://gerrit.openvpn.net/c/openvpn/+/361?usp=email )
Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to
Patchwork
..
dev-tools/gerrit-send-mail.
On Wed, Sep 20, 2023 at 02:15:19PM +0200, Frank Lichtenheld wrote:
> From: Lev Stipakov
>
> While CMake is not the official way to build OpenVPN on Linux,
> it still make sense to support it. Turns out that
>
> HAVE_SETSID, HAVE_OPENLOG and HAVE_SYSLOG
>
> were not set by CMake configure, and
From: Lev Stipakov
While CMake is not the official way to build OpenVPN on Linux,
it still make sense to support it. Turns out that
HAVE_SETSID, HAVE_OPENLOG and HAVE_SYSLOG
were not set by CMake configure, and --daemon and syslog
functionality was broken.
While on it, fix compiler error on
