From: Selva Nair
- An item added to undo-list was not removed on error, causing
attempt to free again in Undo().
Also fix a memory leak possibility in the same context.
Github: fixes OpenVPN/openvpn#232
Signed-off-by: Selva Nair
---
src/openvpnserv/interactive.c | 17 ++---
1
Hi,
On Mon, Jan 30, 2023 at 04:17:30PM +, Gert Doering wrote:
> overlapped_io_init() has a "bool tuntap_buffer" argument which is only
> passed onwards to alloc_buf_sock_tun(), which does nothing with it.
>
> Remove from both functions.
>
> While at it, move alloc_buf_sock_tun() from mtu.c t
Hi,
On Wed, Jan 11, 2023 at 01:42:31AM +0500, Vladislav Grishenko wrote:
> Hi, sure, will do.
> Yes, I???ve noticed undesired code dup in v14 and have fixed everything found
> in v15 rebase, same will be rechecked in v16 of course.
Did you find time to have a look into this?
2.6.0 is out, but si
Currently we have only one slot for renegotiation of the session/keys.
If a replayed/faked packet is inserted by a malicous attacker, the
legimate peer cannot renegotiate anymore.
This commit introduces dynamic tls-crypt. When both peer support this
feature, both peer create a dynamic tls-crypt ke
From: Lev Stipakov
WinAPI uses __stdcall calling convention on x86. Wrong
calling convention causes UB, which in this case breaks
dco-win functionality.
Signed-off-by: Lev Stipakov
---
v2:
- use WINAPI instead of __stdcall
- replace another existing occurence of __stdcall with WINAPI
- u
On 31/01/2023 13:25, Lev Stipakov wrote:
From: Lev Stipakov
WinAPI uses __stdcall calling convention on x86. Wrong
calling convention causes UB, which in this case breaks
dco-win functionality.
Signed-off-by: Lev Stipakov
---
src/openvpn/dco_win.c | 2 +-
1 file changed, 1 insertion(+), 1
From: Lev Stipakov
WinAPI uses __stdcall calling convention on x86. Wrong
calling convention causes UB, which in this case breaks
dco-win functionality.
Signed-off-by: Lev Stipakov
---
src/openvpn/dco_win.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/openvpn/dco_win
On Mon, Jan 30, 2023 at 06:29:33PM +0100, Arne Schwabe wrote:
> The undefined behaviour USAN clang checker found this.
>
> This fix is a bit messy but so are the original structures.
>
Acked-By: Frank Lichtenheld
Well, it doesn't make it worse vOv
Regards,
--
Frank Lichtenheld
__
On Mon, Jan 30, 2023 at 06:29:35PM +0100, Arne Schwabe wrote:
> This allows identifying the source of undefined behaviour more easily
> from the github action logs.
>
> Signed-off-by: Arne Schwabe
> ---
> .github/workflows/build.yaml | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a
On Mon, Jan 30, 2023 at 06:29:34PM +0100, Arne Schwabe wrote:
> The version 3.5.3 triggers undefined behaviour with the usan sanatizer.
> Updating LibreSSSL to 3.7.0 does unfortunately does not fix the issue but
> at least we are now using a current version.
>
> Signed-off-by: Arne Schwabe
> ---
On Mon, Jan 30, 2023 at 06:29:32PM +0100, Arne Schwabe wrote:
> The undefined behaviour USAN clang checker found this. The optimiser
> of clang/gcc will optimise the memcpy away in the auth_token case and output
> excactly the same assembly on amd64/arm64 but it is still better to not rely
> on und
On Sat, Jan 28, 2023 at 04:59:00PM -0500, selva.n...@gmail.com wrote:
> From: Selva Nair
>
> Currently we use the old signal API which follows system-V or
> BSD semantics depending on the platform and/or feature-set macros.
> Further, signal has many weaknesses which makes proper masking
> (defer
12 matches
Mail list logo
