[Openvpn-devel] [PATCH 3/5] Update LibreSSL to 3.7.0 in Github actions

2023-01-30 Thread Arne Schwabe
The version 3.5.3 triggers undefined behaviour with the usan sanatizer. Updating LibreSSSL to 3.7.0 does unfortunately does not fix the issue but at least we are now using a current version. Signed-off-by: Arne Schwabe --- .github/workflows/build.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2

[Openvpn-devel] [PATCH 5/5] Add undefined and abort on error to clang sanaitize builds

2023-01-30 Thread Arne Schwabe
The -fno-sanitize-recover=all flag ensures that for all errors we actually abort the tests in the automated testing and not just print some errors in red that nobody sess. Also add the undefined tests to catch more bugs. For libreSSL we do not add the udefined behaviour as we have (even with the l

[Openvpn-devel] [PATCH 1/5] Fix unaligned access in auth-token

2023-01-30 Thread Arne Schwabe
The undefined behaviour USAN clang checker found this. The optimiser of clang/gcc will optimise the memcpy away in the auth_token case and output excactly the same assembly on amd64/arm64 but it is still better to not rely on undefined behaviour. Signed-off-by: Arne Schwabe --- src/openvpn/auth_

[Openvpn-devel] [PATCH 2/5] Fix unaligned access in macOS/Solaris hwaddr

2023-01-30 Thread Arne Schwabe
The undefined behaviour USAN clang checker found this. This fix is a bit messy but so are the original structures. Signed-off-by: Arne Schwabe --- src/openvpn/route.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/src/openvpn/route.c b/src/

[Openvpn-devel] [PATCH 4/5] Add printing USAN stack trace on github actions

2023-01-30 Thread Arne Schwabe
This allows identifying the source of undefined behaviour more easily from the github action logs. Signed-off-by: Arne Schwabe --- .github/workflows/build.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 6adb69563..13

Re: [Openvpn-devel] [PATCH v2] Get rid of unused 'bool tuntap_buffer' arguments.

2023-01-30 Thread Arne Schwabe
Am 30.01.23 um 17:17 schrieb Gert Doering: overlapped_io_init() has a "bool tuntap_buffer" argument which is only passed onwards to alloc_buf_sock_tun(), which does nothing with it. Remove from both functions. While at it, move alloc_buf_sock_tun() from mtu.c to win32.c and make static. It's o

[Openvpn-devel] [PATCH v2] Get rid of unused 'bool tuntap_buffer' arguments.

2023-01-30 Thread Gert Doering
overlapped_io_init() has a "bool tuntap_buffer" argument which is only passed onwards to alloc_buf_sock_tun(), which does nothing with it. Remove from both functions. While at it, move alloc_buf_sock_tun() from mtu.c to win32.c and make static. It's only ever called from win32.c / overlapped_io_

[Openvpn-devel] [PATCH] Get rid of unused 'bool tuntap_buffer' arguments.

2023-01-30 Thread Gert Doering
overlapped_io_init() has a "bool tuntap_buffer" argument which is only passed onwards to alloc_buf_sock_tun(), which does nothing with it. Remove from both functions. Signed-off-by: Gert Doering --- src/openvpn/mtu.c| 3 +-- src/openvpn/mtu.h| 3 +-- src/openvpn/socket.c | 4 ++-- src/o

[Openvpn-devel] [PATCH 1/2] Fix unaligned access in macOS/Solaris hwaddr and auth-token

2023-01-30 Thread Arne Schwabe
The undefined behaviour USAN clang checker found these two cases. The optimiser of clang/gcc will optimise the memcpy away in the auth_token case and output excactly the same assembly on amd64/arm64 but it is still better to not rely on undefined behaviour. The hw addr fix is a mess but so are the

[Openvpn-devel] [PATCH 2/2] Add undefined and abort on error to clang sanaitize builds

2023-01-30 Thread Arne Schwabe
The -fno-sanitize-recover=all flag ensures that for all errors we actually abort the tests in the automated testing and not just print some errors in red that nobody sess. Also add the undefined tests to catch more bugs Signed-off-by: Arne Schwabe --- .github/workflows/build.yaml | 10 +-

Re: [Openvpn-devel] OpenVPN 2.6.0 released

2023-01-30 Thread Frank Lichtenheld
On Fri, Jan 27, 2023 at 08:41:38PM +0100, Matthias Andree wrote: > Am 25.01.23 um 20:50 schrieb Frank Lichtenheld: > > The OpenVPN community project team is proud to release OpenVPN 2.6.0. > > This is the new stable version of OpenVPN with some major new features. > > Hi Frank, > > OpenVPN 2.5.x