Re: [Openvpn-devel] [PATCH v2 5/5] Improve signal handling using POSIX sigaction

2023-01-20 Thread Selva Nair
On Sun, Jan 8, 2023 at 2:27 PM Gert Doering wrote: > Hi, > > On Mon, Jan 02, 2023 at 02:43:22PM -0500, selva.n...@gmail.com wrote: > > From: Selva Nair > > > > Currently we use the old signal API which follows system-V or > > BSD semantics depending on the platform and/or feature-set macros. > >

[Openvpn-devel] [PATCH applied] Re: Cleanup route error and debug logging on Windows

2023-01-20 Thread Gert Doering
Lots of good unifications, thanks, and thanks for sending the v2 quickly. I have not tested beyond "push at github", but Lev has tested, and I have stared at the changes and liked what I saw :-) - especially the interface ID change fixes "that bug" that I happened to hit when testing the v6-rout

[Openvpn-devel] [PATCH applied] Re: Warn when pkcs11-id or pkcs11-id-management options are ignored

2023-01-20 Thread Gert Doering
As I do not have a working pkcs11-anything environment (still :( ), I have not tested this beyond "looks reasonable" and "compiles on github". Your patch has been applied to the master and release/2.6 branch. commit abad04fc8ef6c1da7dc4e976bacee9f34931adea (master) commit f42b38a68e7a9b44153021a7

[Openvpn-devel] (no subject)

2023-01-20 Thread Mary Karami
___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Warn when pkcs11-id or pkcs11-id-management options are ignored

2023-01-20 Thread Frank Lichtenheld
On Thu, Jan 19, 2023 at 09:18:41PM -0500, selva.n...@gmail.com wrote: > From: Selva Nair > > - If there are no pkcs11-providers either directly specified or > through p11-kit-proxy made available through a build-time detection, > these options are ignored. Log a warning in such cases. > >

Re: [Openvpn-devel] [PATCH v2 2/2] Cleanup route error and debug logging on Windows

2023-01-20 Thread Lev Stipakov
Hi, Stared at the code and slightly tested - works as expected. Nice that we display interface id: add_route_ipv6(2000::/3 -> 2001:db8:0:456::1 metric 200) IF 74 instead of device name: add_route_ipv6(2000::/3 -> 2001:db8:0:456::1 metric 200) dev OpenVPN Data Channel Offload Another thing

[Openvpn-devel] [PATCH v2 2/2] Cleanup route error and debug logging on Windows

2023-01-20 Thread selva . nair
From: Selva Nair Use a unified logging format for various route-methods - Route add/delete errors are always logged with M_WARN, so log only additional information (succeed/exists) with D_ROUTE. - Non-windows platforms log route errors with a prefix "ERROR:" and debug info with "ROUTE:". Do

Re: [Openvpn-devel] [PATCH 2/2] Cleanup route error and debug logging on Windows

2023-01-20 Thread Gert Doering
Hi, On Fri, Jan 13, 2023 at 06:57:54PM -0500, selva.n...@gmail.com wrote: > Use a unified logging format for various route-methods This generally looks good, but I could't get Lev to test it, because the patch does not apply anymore - v2 of the RTA_ macro patch brought "bool ret = ..." change whi