Re: [Openvpn-devel] [OpenVPN/openvpn-gui] UI showing green connected status despite not beeing able to create a route (#9)

2023-01-02 Thread Selva Nair
Hi, On Mon, Jan 2, 2023 at 5:51 PM Gert Doering wrote: > Hi, > > On Sat, Dec 31, 2022 at 05:40:49PM +0100, Gert Doering wrote: > > On Sat, Dec 17, 2022 at 07:09:34PM -0500, Selva Nair wrote: > > > tldr: Can we get CONNECTED,ERROR instead of CONNECTED,SUCCESS on route > > > errors? > > > > I thin

Re: [Openvpn-devel] [OpenVPN/openvpn-gui] UI showing green connected status despite not beeing able to create a route (#9)

2023-01-02 Thread Gert Doering
Hi, On Sat, Dec 31, 2022 at 05:40:49PM +0100, Gert Doering wrote: > On Sat, Dec 17, 2022 at 07:09:34PM -0500, Selva Nair wrote: > > tldr: Can we get CONNECTED,ERROR instead of CONNECTED,SUCCESS on route > > errors? > > I think this makes sense. Not sure how complicated it is, and if we > can mak

Re: [Openvpn-devel] [PATCH 0/5] Improve signals and avoid losing high priority ones

2023-01-02 Thread Selva Nair
Please use v2 for 4/5 and 5/5 -- sorry about the noise. On Sun, Jan 1, 2023 at 4:51 PM wrote: > From: Selva Nair > > Back to my long-forgotten signal patch -- cleaned up and rebased. > What better to do on a Jan 1st afternoon... > > Commits: > > 1. Preparing for better signal handling: some co

[Openvpn-devel] [PATCH v2 5/5] Improve signal handling using POSIX sigaction

2023-01-02 Thread selva . nair
From: Selva Nair Currently we use the old signal API which follows system-V or BSD semantics depending on the platform and/or feature-set macros. Further, signal has many weaknesses which makes proper masking (blocking) of signals during update not possible. Improve this: - Use sigaction to pro

[Openvpn-devel] [PATCH v2 4/5] Fix signal handling on Windows

2023-01-02 Thread selva . nair
From: Selva Nair - In win32_signal_get() re-order the check so that Windows signals are picked up even if signal_received is non-zero - When management is not active, management_sleep() becomes sleep() but it is not interruptible by signals on Windows. Fix this by periodically checking for