Re: [Openvpn-devel] [OpenVPN/openvpn-gui] UI showing green connected status despite not beeing able to create a route (#9)

2022-12-31 Thread Gert Doering
Hi, On Sat, Dec 17, 2022 at 07:09:34PM -0500, Selva Nair wrote: > tldr: Can we get CONNECTED,ERROR instead of CONNECTED,SUCCESS on route > errors? I think this makes sense. Not sure how complicated it is, and if we can make this before 2.6.0 ("some time in January"). gert -- "If was one thing

[Openvpn-devel] [PATCH applied] Re: Use undo_lists for saving ring-buffer handles in interactive service

2022-12-31 Thread Gert Doering
Thanks for bringing this in-line with the existing code style. Light glance-at-code looks reasonable - and there's an ACK from Lev anyway :-) Not tested further. Your patch has been applied to the master and release/2.6 branch. commit 6ea9cf8146b1d72aa6a4790bc3ac2b99562b2cac (master) commit fc9

[Openvpn-devel] [PATCH applied] Re: Cleanup: Close duplicated handles in interactive service

2022-12-31 Thread Gert Doering
Again, thanks for the cleanup. As with 1/2, just glanced at the code change and not explicitly tested (beyond "feed to github actions"). Your patch has been applied to the master and release/2.6 branch. commit a10564c71608dca6172a89dc458e6e23254d600b (master) commit e47c88bbc593f99529712229fae65