Re: [Openvpn-devel] [PATCH v15] Add DNS SRV remote host discovery support

2022-12-28 Thread Vladislav Grishenko
Hi, please refer diff against v14 https://pastebin.com/XA0dWiih -- Best Regards, Vladislav Grishenko ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH v15] Add DNS SRV remote host discovery support

2022-12-28 Thread Vladislav Grishenko
DNS SRV remote host discovery allows to have multiple OpenVPN servers for a single domain w/o explicit profile enumeration, to move services from host to host with little fuss, and to designate hosts as primary servers for a service and others as backups. Feature has been asked several times alread

[Openvpn-devel] [PATCH] Properly unmap ring buffer file-map in interactive service

2022-12-28 Thread selva . nair
From: Selva Nair The return value of MapViewOfFile must be passed to UnmapViewofFile, instead of the file handle. Fixes #206 Signed-off-by: Selva Nair --- src/openvpnserv/interactive.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/openv

[Openvpn-devel] [PATCH applied] Re: options.c: update usage description of --cipher

2022-12-28 Thread Gert Doering
Acked-by: Gert Doering "makes sense" and I can confirm the ((null))... now it's --cipher alg: Encrypt packets with cipher algorithm alg. You should usually use --data-ciphers instead. Set alg=none to disable encryption. Your patch has been applied to the

[Openvpn-devel] [PATCH applied] Re: options.c: fix format security error when compiling without optimization

2022-12-28 Thread Gert Doering
Funny code section... why introduce a variable, when it could have called msg() directly. But anyway. Your patch has been applied to the master and release/2.6 branch. commit 24fc4ce25432a42170477f21133bb0f25a8a860d (master) commit cdcaebcbdf31cb629e54147d476e6fb9921f7999 (release/2.6) Author: F

[Openvpn-devel] [PATCH] options.c: update usage description of --cipher

2022-12-28 Thread Frank Lichtenheld
GCC with -O3 complains: warning: ā€˜%s’ directive argument is null [-Wformat-overflow=] And indeed: --cipher alg: Encrypt packets with cipher algorithm alg (default=(null)). Since there is no real default anymore, remove it. While here also indicate the somewhat-deprecated sta

[Openvpn-devel] OpenVPN 2.6_rc1 released

2022-12-28 Thread Frank Lichtenheld
The OpenVPN community project team is proud to release OpenVPN 2.6_rc1. This is the first release candidate (and the third beta release) for the feature release 2.6.0. Changes since Beta 2: * Officially deprecate NTLMv1 proxy auth method in 2.6. Will be removed in 2.7. * Support unlimited number

Re: [Openvpn-devel] [PATCH] options.c: fix format security error when compiling without optimization

2022-12-28 Thread Arne Schwabe
Am 28.12.22 um 12:07 schrieb Frank Lichtenheld: error: format not a string literal and no format arguments [-Werror=format-security] 2309 | msg(M_USAGE, str); Found by accident, since it only happens without optimization. Seems the compiler can figure out that this is harmless when thinki

[Openvpn-devel] [PATCH] options.c: fix format security error when compiling without optimization

2022-12-28 Thread Frank Lichtenheld
error: format not a string literal and no format arguments [-Werror=format-security] 2309 | msg(M_USAGE, str); Found by accident, since it only happens without optimization. Seems the compiler can figure out that this is harmless when thinking a bit harder about it. Fix anyway. Signed-off-b