[Openvpn-devel] Linking to GUI changes in release announcements

2022-12-07 Thread Selva Nair
Hi, Now that we have a shiny, newly updated, CHANGES.rst file for the GUI, it may be useful to link to it in future release announcements: https://github.com/OpenVPN/openvpn-gui/blob/master/CHANGES.rst Although almost all new features in the GUI were made available incrementally, one feature new

Re: [Openvpn-devel] [PATCH] support PKCS11 lib dependencies

2022-12-07 Thread Selva Nair
Hi, On Tue, Dec 6, 2022 at 8:19 PM Marc Becker via Openvpn-devel < openvpn-devel@lists.sourceforge.net> wrote: > Modify the Win32-PE search path to find dependencies > in shared object origin location. > > Needs https://github.com/OpenSC/pkcs11-helper/pull/59 to work. > Would be nice if this c

[Openvpn-devel] [PATCH applied] Re: Fix unit test of test_pkt on little endian Linux

2022-12-07 Thread Gert Doering
Acked-by: Gert Doering Fed this to Github actions, our buildbot army AND tested this on AIX and Linux. And FreeBSD. Your patch has been applied to the master branch. commit 0f904615bd2eac9d246055ff1ca4e4da95586f86 (master) commit 9c923ef3b435f058a3f898691e3d0613a0357fe5 (release/2.6) Author: A

[Openvpn-devel] [PATCH applied] Re: ChangeLog: Fix encoding

2022-12-07 Thread Gert Doering
Acked-by: Gert Doering Amazing enough, this survived e-mail, being saved and applied on an ISO8859-1 system, and generally being close to me... Verified with od -c that it is, indeed, now UTF8 umlauts in there! 0120440s ) : f i x f o r e i g n _ 0120460

[Openvpn-devel] [PATCH] Fix unit test of test_pkt on little endian Linux

2022-12-07 Thread Arne Schwabe
This surprising breakage results from the fact that Linux basically uses a different structure from the *BSD: For exmaple, macOS has: struct sockaddr_in { __uint8_t sin_len; sa_family_t sin_family; in_port_t sin_port; struct in_addr sin_addr; chars

Re: [Openvpn-devel] [PATCH] disable DCO if --secret is specified

2022-12-07 Thread Arne Schwabe
Am 07.12.22 um 11:02 schrieb Antonio Quartulli: P2P mode with pre-shared key is deprecated, unsecure and should NOT be used. This said we still carry it around for a bit and we have to make sure it does not fights with DCO. Disable DCO at all when --secret is specified. Signed-off-by: Antonio Q

[Openvpn-devel] [PATCH applied] Re: disable DCO if --secret is specified

2022-12-07 Thread Gert Doering
Acked-by: Gert Doering Nicely trivial, and gets the job done :-) - Dec 7 11:21:02 ubuntu2004 tun-udp-p2p[1139052]: --secret is set. Disabling data channel offload .. and subsequently, tests succeed, and the instance does not crash anymore. Thanks. (Tested only on the Linux/DCO Server + Cli

[Openvpn-devel] [PATCH 2.6] ChangeLog: Fix encoding

2022-12-07 Thread Frank Lichtenheld
Convert to UTF-8. Also collapse entries "Richard Bonhomme" and "Richard T Bonhomme". Signed-off-by: Frank Lichtenheld --- ChangeLog | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index d1a47dec..64ec4bff 100644 --- a/ChangeLog +++ b/ChangeLog

[Openvpn-devel] [PATCH] disable DCO if --secret is specified

2022-12-07 Thread Antonio Quartulli
P2P mode with pre-shared key is deprecated, unsecure and should NOT be used. This said we still carry it around for a bit and we have to make sure it does not fights with DCO. Disable DCO at all when --secret is specified. Signed-off-by: Antonio Quartulli --- src/openvpn/dco.c | 6 ++ 1 fil

Re: [Openvpn-devel] OpenVPN crash with latest "fix p2p reconnect" patch

2022-12-07 Thread Gert Doering
Hi, On Wed, Dec 07, 2022 at 08:56:04AM +0100, Gert Doering wrote: > the client side tests tested p2p udp (8) before p2p udp TLS (11), so > never noticed that after running (11), (8) would not work any longer... More specifically, because I never tested p2p tun (8) on the DCO-enabled servers ("why