[Openvpn-devel] [PATCH applied] Re: implement --session-timeout

2022-10-07 Thread Gert Doering
Acked-by: Gert Doering This is a useful addition for situations with external constraints ("this VPN access may only be used between 10:00 and 18:00", so you can ensure the session ends at 17:59:59 without having extra managmeent logic around). Whether it's overly useful in "global server contex

[Openvpn-devel] [PATCH] Allow Authtoken lifetime to be short than renegotiation time

2022-10-07 Thread Arne Schwabe
Currently the life time of the auth-token is tied to the reneogotiation time. While this is fine for many setups, some setups prefer a user to be no longer authenticated when the user disconnects from the VPN for a certain amount of time. This commit allows to shorten the renewal time of the auth-

[Openvpn-devel] [PATCH applied] Re: Document/cleanup event_timeout functions

2022-10-07 Thread Gert Doering
Thanks for the thorough review. I have adjusted the 3 minor nits in the comments, as instructed. I have also removed the spurious blank line. The code change looks huge, indeed, unless viewed with "-w" - then it's quite straightforward. For good measure I've still subjected this to the server

Re: [Openvpn-devel] [PATCH 5/6] uncrustify: add space around all arithmetic operators

2022-10-07 Thread Frank Lichtenheld
On Fri, Aug 26, 2022 at 10:54:26AM +0200, Frank Lichtenheld wrote: > Signed-off-by: Frank Lichtenheld > --- > dev-tools/uncrustify.conf | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/dev-tools/uncrustify.conf b/dev-tools/uncrustify.conf > index 3c721396..d5c2a8a7 1006

Re: [Openvpn-devel] [PATCH 4/6] reformat for sp_arith_additive=add

2022-10-07 Thread Frank Lichtenheld
On Fri, Aug 26, 2022 at 10:54:25AM +0200, Frank Lichtenheld wrote: > Signed-off-by: Frank Lichtenheld Note: This patch doesn't apply cleanly anymore due to a conflict in tun.c. But obviously it can trivially be recreated, since it is just a call to ./dev-tools/reformat-all.sh. Let me know if you

Re: [Openvpn-devel] route/iroute handling on FreeBSD

2022-10-07 Thread Kristof Provost
Hi Gert, On 6 Oct 2022, at 16:39, Gert Doering wrote: > FreeBSD DCO has the open issue of "iroute with the same netmask as > route, so we want metric/weight/... to differenciate" > I’ll try to dig into that, but it’ll be late next week at the earliest. Best regards, Kristof

Re: [Openvpn-devel] route/iroute handling on FreeBSD

2022-10-07 Thread Gert Doering
Hi, On Fri, Oct 07, 2022 at 10:47:08AM +0100, Kristof Provost wrote: > On 6 Oct 2022, at 16:39, Gert Doering wrote: > > FreeBSD DCO has the open issue of "iroute with the same netmask as > > route, so we want metric/weight/... to differenciate" > I???ll try to dig into that, but it???ll be late ne

Re: [Openvpn-devel] [PATCH v2] Document/cleanup event_timeout functions

2022-10-07 Thread Frank Lichtenheld
On Thu, Oct 06, 2022 at 02:29:40PM +0200, Arne Schwabe wrote: > Remove function event_timeout_clear_ret as it is unused. > > Cleanup event_timeout_trigger a bit. Do an instant return false if the > timeout is not defined and inline local_now and use > event_timeout_remaining instead of local dupli