[Openvpn-devel] [PATCH applied] Re: solaris/open_tun: prevent crash when dev is empty string

Acked-by: Gert Doering I'm not sure how "dev" can ever be an empty string here, but if it can be one, we shouldn't crash :-) - subjected to t_client tests on OpenIndiana 2019 that excercise --dev tun/tap and --dev tun3/tap3 Trying around a bit, I came up with "openvpn --dev '' --dev-type tun" wh

Re: [Openvpn-devel] [PATCH v4 release/2.5] msvc: add branch name and commit hash to version output

This may be extreme nitpicking... +l = ["detached\n"] > +branch = "/" .join(l)[:-1] > Use "none" instead of "detached"? The logic being: we are trying to add the branch name to the version, so "none" if not on a branch, "unknown' if the branch cannot be determined. By the way, autoto

Re: [Openvpn-devel] [PATCH] Document/cleanup event_timeout functions

On Fri, Sep 23, 2022 at 10:58:04AM +0200, Arne Schwabe wrote: > Remove function event_timeout_clear_ret as it is unused. > > Cleanup event_timeout_trigger a bit. Do an instant return false if the > timeout is not defined and inline local_now and use > event_timeout_remaining instead of local dupli

[Openvpn-devel] [PATCH v4] msvc: add branch name and commit hash to version output

From: Lev Stipakov Add a simple python script which generates header with branch name and commit hash #defines. While on it, fix filename in msvc-generate.vcxproj and add proper copyright header to Makefile.mak. Signed-off-by: Lev Stipakov --- v4: - replace backslash with slash - instead

[Openvpn-devel] [PATCH] Document/cleanup event_timeout functions

Remove function event_timeout_clear_ret as it is unused. Cleanup event_timeout_trigger a bit. Do an instant return false if the timeout is not defined and inline local_now and use event_timeout_remaining instead of local duplicated code. Add doxygen comments for all timeout function, especially f

[Openvpn-devel] [PATCH v4 release/2.5] msvc: add branch name and commit hash to version output

From: Lev Stipakov Add a simple python script which generates header with branch name and commit hash #defines. While on it, fix filename in msvc-generate.vcxproj and add proper copyright header to Makefile.mak. Signed-off-by: Lev Stipakov --- v4: - replace backslash with slash - instead o

[Openvpn-devel] [PATCH v3 release/2.5] msvc: add branch name and commit hash to version output

From: Lev Stipakov Add a simple python script which generates header with branch name and commit hash #defines. While on it, fix filename in msvc-generate.vcxproj and add proper copyright header to Makefile.mak. Signed-off-by: Lev Stipakov --- v3: - properly handle branchnames like release

[Openvpn-devel] [PATCH v3] msvc: add branch name and commit hash to version output

From: Lev Stipakov Add a simple python script which generates header with branch name and commit hash #defines. While on it, fix filename in msvc-generate.vcxproj and add proper copyright header to Makefile.mak. Signed-off-by: Lev Stipakov --- v3: - properly handle branchnames like release/