Re: [Openvpn-devel] [PATCH v3 26/28] Allow setting control channel packet size with tls-mtu

2022-09-15 Thread Heiko Hund
This patch need to be rebased again, does not apply to master anymore: checking file src/openvpn/ssl.c Hunk #1 succeeded at 297 (offset 1 line). Hunk #2 FAILED at 321. Hunk #3 succeeded at 1256 (offset -42 lines). On Mittwoch, 11. Mai 2022 13:08:10 CEST Arne Schwabe wrote: > @@ -141,6 +147,8 @@ Us

Re: [Openvpn-devel] [PATCH v3] Improve data key id not found error message

2022-09-15 Thread Frank Lichtenheld
On Wed, Sep 14, 2022 at 07:25:27PM +0200, Arne Schwabe wrote: > With delayed data key generation now with deferred auth, NCP and similar > mechanism the "TLS Error: local/remote TLS keys are out of sync" is shown > much too frequent and confuses a lot of people. > > This also removes the dead code

Re: [Openvpn-devel] [PATCH v4] Use DCO on Windows by default

2022-09-15 Thread Frank Lichtenheld
On Thu, Sep 15, 2022 at 02:11:34PM +0200, Frank Lichtenheld wrote: > Acked-by: Frank Lichtenheld Also put this through buildbot and saw no failures. Regards, -- Frank Lichtenheld ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net h

Re: [Openvpn-devel] [PATCH] doc: add "ovpn-dco" to usage and man page

2022-09-15 Thread Frank Lichtenheld
Did you not move the "(default)" to ovpn-dco since the other patch, that makes ovpn-doc the default, is not merged, yet? Patch is certainly correct relative to current master, so Acked-by: Frank Lichtenheld On Thu, Sep 15, 2022 at 03:03:49PM +0300, Lev Stipakov wrote: > From: Lev Stipakov > >

Re: [Openvpn-devel] [PATCH v4] Use DCO on Windows by default

2022-09-15 Thread Frank Lichtenheld
On Thu, Sep 15, 2022 at 01:40:28PM +0300, Lev Stipakov wrote: > From: Lev Stipakov > > On startup, check following conditions: > > - ovpn-dco-win driver is installed. Perform this check > by trying to open adapter by symbolic name. > > - options are compatible with dco. Same checks as on > Li

[Openvpn-devel] [PATCH] doc: add "ovpn-dco" to usage and man page

2022-09-15 Thread Lev Stipakov
From: Lev Stipakov While on it, remove redundant sentence and quotation from --windows-driver man description. Signed-off-by: Lev Stipakov --- doc/man-sections/windows-options.rst | 8 src/openvpn/options.c| 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff -

[Openvpn-devel] [PATCH v4] Use DCO on Windows by default

2022-09-15 Thread Lev Stipakov
From: Lev Stipakov On startup, check following conditions: - ovpn-dco-win driver is installed. Perform this check by trying to open adapter by symbolic name. - options are compatible with dco. Same checks as on Linux and FreeBSD. In addition, check that --mode server is not used and --windows

Re: [Openvpn-devel] [PATCH v3] Use DCO on Windows by default

2022-09-15 Thread Frank Lichtenheld
On Wed, Sep 14, 2022 at 09:43:37PM +0300, Lev Stipakov wrote: > From: Lev Stipakov [...] > v3: > - simplify #ifdefs, as per Frank's suggestions > [...] > diff --git a/src/openvpn/options.c b/src/openvpn/options.c > index 2e567571..e615a71e 100644 > --- a/src/openvpn/options.c > +++ b/src/openv