Re: [Openvpn-devel] [PATCH] dco: disable DCO if --allow-compress yes/asym was specified

2022-08-05 Thread Arne Schwabe
Am 05.08.22 um 17:13 schrieb Antonio Quartulli: Allowing compression means that we may accept a pushable compress setting. This scenario can't work with DCO therefore disable it when compression is allowed. Acked-By: Arne Schwabe ___ Openvpn-deve

[Openvpn-devel] [PATCH] dco: disable DCO if --allow-compress yes/asym was specified

2022-08-05 Thread Antonio Quartulli
Allowing compression means that we may accept a pushable compress setting. This scenario can't work with DCO therefore disable it when compression is allowed. Signed-off-by: Antonio Quartulli --- src/openvpn/dco.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/open

[Openvpn-devel] [PATCH] dco: perform pull options check only if we pulled any option

2022-08-05 Thread Antonio Quartulli
The do_deferred_options() function is invoked also on the server side in order to process all negotiated bits. However, in this case we should not perform any pull options check, as it's required only on the client side. Move check within the "if (options.pull)" block to ensure we perform the che

[Openvpn-devel] [PATCH applied] Re: dco: implement dco support for p2mp/server code path

2022-08-05 Thread Gert Doering
Acked-by: Gert Doering v2 has an ACK from Heiko, so recording that. OTOH v3 is substantially different (the dco.c hunk was missing from v1+v2 - hidden in 13/25 v1 - and the multi.c tls_keys stuff is quite different), so I gave this my own stare-at-code, and of course the full test set. The fin

[Openvpn-devel] duplicate MAC addresses on TAP on FreeBSD 12+

2022-08-05 Thread Gert Doering
Hi, our buildbots had quite some amount of "unexplained failures" on the TAP adapter tests on FreeBSD 12 and FreeBSD 13 recently, which turned out to be "duplicate MAC address" (so when I ran the tests individually, everything worked, and when buildbot fired up all clients in parallel, depending o

[Openvpn-devel] [PATCH applied] Re: Break 'try 256 dco devices' loop on EPERM

2022-08-05 Thread Gert Doering
Of course I have tested this, very scientifically, like "do two runs with and without sufficient permissions on a DCO-enabled system" :-) Patch has been applied to the master branch. commit 78c02dd12bcfe7c4b4e96ea534b39ade9ee2c4d6 Author: Gert Doering Date: Thu Aug 4 10:25:02 2022 +0200 B

[Openvpn-devel] [PATCH applied] Re: dco: add documentation for ovpn-dco-linux

2022-08-05 Thread Gert Doering
Taking an easy one out of sequence... (but it means I have to tackle 14/ really quick now, otherwise this is all wrong). Your patch has been applied to the master branch. commit fba724e3fc958b5704dc22dd14ec93f4bb4d9e34 Author: Antonio Quartulli Date: Fri Aug 5 11:37:03 2022 +0200 dco: add

Re: [Openvpn-devel] [PATCH v3 15/25] dco: add documentation for ovpn-dco-linux

2022-08-05 Thread Frank Lichtenheld
On Fri, Aug 05, 2022 at 11:37:03AM +0200, Antonio Quartulli wrote: > Signed-off-by: Antonio Quartulli > --- > > Changes from v2: > * more adjustments Acked-By: Frank Lichtenheld Regards, -- Frank Lichtenheld ___ Openvpn-devel mailing list Openvp

Re: [Openvpn-devel] [PATCH] PUSH_BUNDLE_SIZE is too short

2022-08-05 Thread Angel Abad
El vie, 5 ago 2022 a las 9:59, Gert Doering () escribió: > Hi, > > On Fri, Aug 05, 2022 at 08:58:05AM +0200, Angel Abad wrote: > > Hi, sorry for my late reply! > > > > We use on server side managed AWS Clientvpn product[1], but we havent the > > problem with macosX or windows laptops, only with li

[Openvpn-devel] [PATCH v3 15/25] dco: add documentation for ovpn-dco-linux

2022-08-05 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli --- Changes from v2: * more adjustments Changes from v1: * removed text about TCP drop (cannot reproduce at the moment) * clarified version requirements for p2p and client mode --- Changes.rst | 9 ++ README.dco.md

Re: [Openvpn-devel] [PATCH] PUSH_BUNDLE_SIZE is too short

2022-08-05 Thread Arne Schwabe
Am 05.08.2022 um 08:58 schrieb Angel Abad: Hi, sorry for my late reply! We use on server side managed AWS Clientvpn product[1], but we havent the problem with macosX or windows laptops, only with linux (ubuntu, centos and debian). OpenVPN Connect which is based on OpenVPN 3.x might be more

Re: [Openvpn-devel] [PATCH v2 15/25] dco: add documentation for ovpn-dco-linux

2022-08-05 Thread Frank Lichtenheld
On Fri, Aug 05, 2022 at 08:58:44AM +0200, Antonio Quartulli wrote: > Signed-off-by: Antonio Quartulli > --- > > Changes from v1: > * removed text about TCP drop (cannot reproduce at the moment) > * clarified version requirements for p2p and client mode > --- > Changes.rst

Re: [Openvpn-devel] [PATCH] PUSH_BUNDLE_SIZE is too short

2022-08-05 Thread Gert Doering
Hi, On Fri, Aug 05, 2022 at 08:58:05AM +0200, Angel Abad wrote: > Hi, sorry for my late reply! > > We use on server side managed AWS Clientvpn product[1], but we havent the > problem with macosX or windows laptops, only with linux (ubuntu, centos and > debian). Which clients are you using on Mac