Re: [Openvpn-devel] [PATCH v2 10/25] dco: periodically check and possibly rotate/delete keys

2022-08-01 Thread Frank Lichtenheld
On Thu, Jul 28, 2022 at 09:35:42PM +0200, Antonio Quartulli wrote: > Data channel keys are periodically regenarated and installed in > ovpn-dco. > However, there is a certain moment when keys are rotated in order > to elect the new primary one. > > Check the key status in userspace so that kernels

[Openvpn-devel] [PATCH applied] Re: disable DCO if no --dev was specified

2022-08-01 Thread Gert Doering
Acked-by: Gert Doering The broken bit was added quite a few patches ago, but wasn't caught by my testing, because it needed --enable-dco *and* DCO-in-kernel - otherwise, the DCO paths would disable themselves, and not crash :-) Tested on ubuntu 20 with DCO kernel support - without this, $ ope

[Openvpn-devel] [PATCH applied] Re: dco: configure keys in DCO right after generating them

2022-08-01 Thread Gert Doering
Tests without --enable-dco (full server side test) - passes everything. Test with --enable-dco but no Kernel support (client side only) - also passes everything (spurious failure on one of the p2p tests, but that was likely related to "too many tests running in parallel"). Did not test on a syste

[Openvpn-devel] [PATCH applied] Re: xkey_provider: fix building with --disable-management

2022-08-01 Thread Gert Doering
Thanks for v2, and "too many #ifdef" indeed. Uncrustify complained that one of the #endif wants a comment, but with the new commit hooks this is easily fixed. (Maybe we want to have a deep look into "do we really want to keep ENABLE_MANAGEMENT?" one day... how much extra code size does that brin

[Openvpn-devel] [PATCH] disable DCO if no --dev was specified

2022-08-01 Thread Antonio Quartulli
The DCO logic is uanble to proceed without --dev argument, therefore just disable DCO if no --dev was specified by the user. Right now, calling openvpn with DCO enabled (default) and no --dev specified leads to a crash, because --dev is assumed to always be there. Reported-by: Frank Lichtenheld

[Openvpn-devel] [PATCH applied] Re: dco: configure keys in DCO right after generating them

2022-08-01 Thread Gert Doering
Tests without --enable-dco (full server side test) - passes everything. Test with --enable-dco but no Kernel support (client side only) - also passes everything (spurious failure on one of the p2p tests, but that was likely related to "too many tests running in parallel"). Did not test on a syste

Re: [Openvpn-devel] [PATCH v2 14/25] dco: implement dco support for p2mp/server code path

2022-08-01 Thread Heiko Hund
On Donnerstag, 28. Juli 2022 21:55:01 CEST Antonio Quartulli wrote: > This change introduces ovpn-dco support along the p2mp/server code path. > Some code seems to be duplicate of the p2p version, but details are > different, so it couldn't be shared. > > Signed-off-by: Antonio Quartulli > --- >

Re: [Openvpn-devel] [PATCH] PUSH_BUNDLE_SIZE is too short

2022-08-01 Thread Arne Schwabe
Am 24.07.22 um 19:46 schrieb Angel Abad: Description: PUSH_BUNDLE_SIZE is too short Author: Angel Abad --- Hello, we have problem with a large used openvpn server, our server push to clients almos 150 routes, we havent problem with windows clients, but with linux clients push options are cut,

[Openvpn-devel] [PATCH v4 2/5] Allow tun-mtu to be pushed

2022-08-01 Thread Arne Schwabe
This allows tun-mtu to pushed but only up to the size of the preallocated buffers. This is not a perfect solution but should allow most of the use cases where the mtu is close enough to 1500. Signed-off-by: Arne Schwabe Patch v4: rebase for check_session_cipher name change --- Changes.rst

[Openvpn-devel] [PATCH applied] Re: Extract check_session_cipher into standalone function

2022-08-01 Thread Gert Doering
This is technically the same as 1/5 in v3, except s/update/check/, and *that* one is is exactly the same patch as "3/6" in the earlier patch series (20220621161649.2872985-3-a...@rfc2549.org) which had an ACK from Frank -> applying that ACK here, adding my own. Stare-at-code and --color-moved=zebr