[Openvpn-devel] [PATCH applied] Re: networking: fix doc for net_iface_new() API

Easy enough ;-) - Heiko just beat me to ACKing it. Have not tested anything! Your patch has been applied to the master branch. commit d5315a5d7400a26f1113bbc44766d49dd0c3688f Author: Antonio Quartulli Date: Tue Jul 5 11:18:42 2022 +0200 networking: fix doc for net_iface_new() API S

Re: [Openvpn-devel] [PATCH 21/25] do_open_tun: restyle "can preserve TUN" check

Hi, On 05/07/2022 14:31, Heiko Hund wrote: On Freitag, 24. Juni 2022 10:38:05 CEST Antonio Quartulli wrote: The current condition checking if the TUN interface was preserved is dependant on the platform being Android or not. This makes the code reasonably ugly, especially because uncrustify can

Re: [Openvpn-devel] [PATCH 14/25] dco: implement dco support for p2mp/server code path

Am 05.07.2022 um 16:53 schrieb Antonio Quartulli: Hi, On 05/07/2022 14:31, Heiko Hund wrote: On Freitag, 24. Juni 2022 10:37:58 CEST Antonio Quartulli wrote: +    uint8_t *ptr = BPTR(&dco->dco_packet_in); +    uint8_t op = ptr[0] >> P_OPCODE_SHIFT; +    if (op == P_DATA_V2 || op == P_DATA_V2)

Re: [Openvpn-devel] [PATCH 14/25] dco: implement dco support for p2mp/server code path

Hi, On 05/07/2022 14:31, Heiko Hund wrote: On Freitag, 24. Juni 2022 10:37:58 CEST Antonio Quartulli wrote: +uint8_t *ptr = BPTR(&dco->dco_packet_in); +uint8_t op = ptr[0] >> P_OPCODE_SHIFT; +if (op == P_DATA_V2 || op == P_DATA_V2) This looks odd. Seems you wanted to check for a s

Re: [Openvpn-devel] [PATCH 15/25] dco: add documentation for ovpn-dco-linux

Hi, On 05/07/2022 14:31, Heiko Hund wrote: On Freitag, 24. Juni 2022 10:37:59 CEST Antonio Quartulli wrote: +application. Note that DCO will use DATA_V2 packets in P2P mode, therefore, +this implies that peers must be running 2.6.0+ in order to have P2P-NCP +which brings DATA_V2 pac

Re: [Openvpn-devel] [PATCH 22/25] dco-win: introduce low-level code for handling ovpn-dco-win in Windows

Hi, On 05/07/2022 14:32, Heiko Hund wrote: On Freitag, 24. Juni 2022 10:38:06 CEST Antonio Quartulli wrote: +int +dco_del_key(dco_context_t *dco, unsigned int peerid, dco_key_slot_t slot) +{ +msg(D_DCO, "%s: peer-id %d, slot %d called but ignored", __func__, peerid, +slot); +/*

Re: [Openvpn-devel] [PATCH 13/25] dco: implement dco support for p2p/client code path

Hi, On 05/07/2022 14:30, Heiko Hund wrote: On Freitag, 24. Juni 2022 10:37:57 CEST Antonio Quartulli wrote: +/* These inet_pton conversion are fatal since options.c already implements + * checks to have only valid addresses when setting the options */ +if (c->options.ifconfig_ipv6_r

Re: [Openvpn-devel] [PATCH] networking: fix doc for net_iface_new() API

On Dienstag, 5. Juli 2022 11:18:42 CEST Antonio Quartulli wrote: > Some auto correction must have sneaked in. > Restore proper wording. > > Signed-off-by: Antonio Quartulli > --- > src/openvpn/networking.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/openvpn/ne

Re: [Openvpn-devel] [PATCH 02/25] dco: add helper function to detect if DCO is enabled or not

On Freitag, 24. Juni 2022 10:37:46 CEST Antonio Quartulli wrote: > +/** > + * Returns whether the current configuration has dco enabled. > + */ > +static inline bool > +dco_enabled(const struct options *o) > +{ > +return !o->tuntap_options.disable_dco; > +} I think it would be beneficial if th

Re: [Openvpn-devel] [PATCH 08/25] dco: allow user to disable it at runtime

On Freitag, 24. Juni 2022 10:37:52 CEST Antonio Quartulli wrote: > +else if (streq(p[0], "disable-dco") || streq(p[0], "dco-disable")) Don't think we need to be backwards compatible here, or do we? ___ Openvpn-devel mailing list Openvpn-devel@li

Re: [Openvpn-devel] [PATCH 24/25] dco-win: add documentation to README.dco.md

On Freitag, 24. Juni 2022 10:38:08 CEST Antonio Quartulli wrote: > +Getting started (Windows) > +- > +Getting started under windows is currently for brave people having > experience > +with windows development. You need to compile openvpn yourself > and also need > +to get

Re: [Openvpn-devel] [PATCH 23/25] dco-win: implement ovpn-dco support in P2P Windows code path

On Freitag, 24. Juni 2022 10:38:07 CEST Antonio Quartulli wrote: > +if (!is_windco(c->c1.tuntap)) [...] > +if ((options->windows_driver == > WINDOWS_DRIVER_WINTUN || options->windows_driver == WINDOWS_DRIVER_WINDCO) [...] > +create_socket_windco(struct context *c, struct link_socket *so

Re: [Openvpn-devel] [PATCH 21/25] do_open_tun: restyle "can preserve TUN" check

On Freitag, 24. Juni 2022 10:38:05 CEST Antonio Quartulli wrote: > The current condition checking if the TUN interface was preserved is > dependant on the platform being Android or not. This makes the code > reasonably ugly, especially because uncrustify can't indent properly. > > On top of that,

Re: [Openvpn-devel] [PATCH 14/25] dco: implement dco support for p2mp/server code path

On Freitag, 24. Juni 2022 10:37:58 CEST Antonio Quartulli wrote: > +uint8_t *ptr = BPTR(&dco->dco_packet_in); > +uint8_t op = ptr[0] >> P_OPCODE_SHIFT; > +if (op == P_DATA_V2 || op == P_DATA_V2) This looks odd. Seems you wanted to check for a second opcode, or is it obsolete? > +

Re: [Openvpn-devel] [PATCH 20/25] dco-win: add platform dependant check on incompatible options

On Freitag, 24. Juni 2022 10:38:04 CEST Antonio Quartulli wrote: > Some platforms may have different constraints in terms of incompatible > opions, therefore we add a function that explicitly checks those. > > Also, add generic option check for when ovpn-dco-win is in use. > > Signed-off-by: Anto

Re: [Openvpn-devel] [PATCH 22/25] dco-win: introduce low-level code for handling ovpn-dco-win in Windows

On Freitag, 24. Juni 2022 10:38:06 CEST Antonio Quartulli wrote: > +int > +dco_del_key(dco_context_t *dco, unsigned int peerid, dco_key_slot_t slot) > +{ > +msg(D_DCO, "%s: peer-id %d, slot %d called but ignored", __func__, > peerid, +slot); > +/* FIXME: Implement in driver first */

Re: [Openvpn-devel] [PATCH 15/25] dco: add documentation for ovpn-dco-linux

On Freitag, 24. Juni 2022 10:37:59 CEST Antonio Quartulli wrote: > +application. Note that DCO will use DATA_V2 packets > in P2P mode, therefore, > +this implies that peers must be running 2.6.0+ > in order to have P2P-NCP > +which brings DATA_V2 packet support. [...] > +- OpenVPN 2.4

Re: [Openvpn-devel] [PATCH 18/25] dco: turn supported ciphers list into a function

On Freitag, 24. Juni 2022 10:38:02 CEST Antonio Quartulli wrote: > Other platforms may need more complex logic to decide whether a cipher > is supported or not, therefore turn hardcoded list into a function that > can be implemented by each platform independently. > > Signed-off-by: Lev Stipakov

Re: [Openvpn-devel] [PATCH 13/25] dco: implement dco support for p2p/client code path

On Freitag, 24. Juni 2022 10:37:57 CEST Antonio Quartulli wrote: > +/* These inet_pton conversion are fatal since options.c already > implements > + * checks to have only valid addresses when setting the > options */ > +if (c->options.ifconfig_ipv6_remote) > +{ > +if (inet

Re: [Openvpn-devel] [PATCH 25/25] dco-win: update GH Actions config file

We have moved dco-win uapi header to openvpn repo, so we don't have to checkout ovpn-dco-win repo to get it - this is what this commit does. But yeah, good point on having dco builds without dco. ti 5. heinäk. 2022 klo 12.36 Antonio Quartulli (a...@unstable.cc) kirjoitti: > > Hi, > > On 05/07/2022

Re: [Openvpn-devel] [PATCH 25/25] dco-win: update GH Actions config file

Hi, On 05/07/2022 11:32, Frank Lichtenheld wrote: I think this commit could use an additional sentence in the commit message on why exactly you remove this? Doesn't immediately make sense to me. To be honest, I am not even sure why we have a build with DCO in the first place. There is no DCO

Re: [Openvpn-devel] [PATCH 25/25] dco-win: update GH Actions config file

I think this commit could use an additional sentence in the commit message on why exactly you remove this? Doesn't immediately make sense to me. On Fri, Jun 24, 2022 at 10:38:09AM +0200, Antonio Quartulli wrote: > Signed-off-by: Lev Stipakov > Signed-off-by: Antonio Quartulli > --- > .github/w

[Openvpn-devel] [PATCH] networking: fix doc for net_iface_new() API

Some auto correction must have sneaked in. Restore proper wording. Signed-off-by: Antonio Quartulli --- src/openvpn/networking.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/openvpn/networking.h b/src/openvpn/networking.h index 647718e0..79963756 100644 --- a/src/ope

[Openvpn-devel] Community meetings in July 2022

Hi, Next community meetings have been scheduled to - Wed 6th July 2022 at 10:30 CEST - Wed 13th July 2022 at 10:30 CEST - Wed 20th July 2022 at 10:30 CEST - Wed 27th July 2022 at 10:30 CEST The place is #openvpn-meeting IRC channel at libera.chat Meeting agendas and summaries are in here: