Re: [Openvpn-devel] [PATCH] Fix auth-token usage with management-def-auth

2022-07-04 Thread Selva Nair
Hi On Mon, Jul 4, 2022 at 5:50 AM Arne Schwabe wrote: > Am 04.07.22 um 04:58 schrieb selva.n...@gmail.com: > > From: Selva Nair > > > > When auth-token verify succeeds during a reauth, other auth > > methods (plugin, script, management) are skipped unless > > external-auth is in effect (skip_au

Re: [Openvpn-devel] [PATCH] Fix auth-token usage with management-def-auth

2022-07-04 Thread Arne Schwabe
Am 04.07.22 um 04:58 schrieb selva.n...@gmail.com: From: Selva Nair When auth-token verify succeeds during a reauth, other auth methods (plugin, script, management) are skipped unless external-auth is in effect (skip_auth gets set to true). However, in this case, the status of management-def-a

Re: [Openvpn-devel] [PATCH 16/25] GitHub Actions: add Linux DCO build (on Ubuntu 20.04)

2022-07-04 Thread Frank Lichtenheld
On Fri, Jun 24, 2022 at 10:38:00AM +0200, Antonio Quartulli wrote: > Signed-off-by: Antonio Quartulli > --- > .github/workflows/build.yaml | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > Looks good to me. Also note that this can applied on current master without waiting for th

Re: [Openvpn-devel] [PATCH 17/25] tun: extract close_tun_handle into its own fucntion and print correct type

2022-07-04 Thread Frank Lichtenheld
On Fri, Jun 24, 2022 at 10:38:01AM +0200, Antonio Quartulli wrote: > From: Arne Schwabe > > This moves closing the tun handle into its own function and also prints > the adapter type we are operating on, instead hardcoding it to > tap-windows. > > While at it, set the handle to NULL after closin

Re: [Openvpn-devel] [PATCH 15/25] dco: add documentation for ovpn-dco-linux

2022-07-04 Thread Antonio Quartulli
Hi, On 04/07/2022 10:29, Frank Lichtenheld wrote: On Fri, Jun 24, 2022 at 10:37:59AM +0200, Antonio Quartulli wrote: [...] +Current implementation limitations +--- +- --persistent-tun not tested/supported +- fallback to non-dco in client mode missing +- IPv6 mapped IPv4 addresse

Re: [Openvpn-devel] [PATCH] Fix auth-token usage with management-def-auth

2022-07-04 Thread Connor Edwards via Openvpn-devel
Looks good. Shortly after my last email about the issue I found this bit of code and also came to the conclusion it was faulty. Thanks for the patch Selva. -- *This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they

Re: [Openvpn-devel] [PATCH 15/25] dco: add documentation for ovpn-dco-linux

2022-07-04 Thread Frank Lichtenheld
On Fri, Jun 24, 2022 at 10:37:59AM +0200, Antonio Quartulli wrote: [...] > +Current implementation limitations > +--- > +- --persistent-tun not tested/supported > +- fallback to non-dco in client mode missing > +- IPv6 mapped IPv4 addresses need Linux 5.4.189+/5.10.110+/5.12+ to wor