Re: [Openvpn-devel] [PATCH applied] Re: Fix M_ERRNO behavior on Windows

Hi, On Thu, May 12, 2022 at 08:32:49AM +0200, Gert Doering wrote: > I have come late to the party, but really, code like this should be > avoided: > > +bool unreachable = error_code == > +#ifdef _WIN32 > +WSAENETUNREACH; > +#else > +ENETUNREACH; > +#endif Even wor

[Openvpn-devel] [PATCH applied] Re: Fix M_ERRNO behavior on Windows

Your patch has been applied to the release/2.5 branch. S-O-B added. commit 4e5b14012550bf934dcf850547b542afa4d6605a Author: Lev Stipakov Date: Wed May 4 12:13:05 2022 +0300 Fix M_ERRNO behavior on Windows Acked-by: Selva Nair Message-Id: <20220504091305.434-1-lstipa...@gmail.c

[Openvpn-devel] [PATCH applied] Re: Fix M_ERRNO behavior on Windows

Your patch has been applied to the master branch. I've added the S-O-B line according to our developer documentation. I have come late to the party, but really, code like this should be avoided: +bool unreachable = error_code == +#ifdef _WIN32 +WSAENETUNREACH; +#else +

[Openvpn-devel] [PATCH applied] Re: Implement --mtu-disc for IPv6 UDP sockets.

Patch has been applied to the master branch. commit 043c67f36342969cd171d24c70ee6b62ebc95fee Author: Gert Doering Date: Tue Feb 22 15:35:14 2022 +0100 Implement --mtu-disc for IPv6 UDP sockets. Signed-off-by: Gert Doering Acked-by: Arne Schwabe Message-Id: <20220222143514

Re: [Openvpn-devel] [PATCH release/2.5] Fix M_ERRNO behavior on Windows

Acked-by: Selva Nair Same as the patch 2429 for master except for the minor change in x_check_status() to match 2.5. On Wed, May 4, 2022 at 5:13 AM Lev Stipakov wrote: > From: Lev Stipakov > > We use M_ERRNO flag in logging to display error code > a

Re: [Openvpn-devel] [PATCH] Implement ED448 and ED25519 support in xkey_provider

Hi, On Tue, May 10, 2022 at 7:32 AM Arne Schwabe wrote: > OpenSSL's implementation of ED448 and ED25519 has a few idiosyncrasies. > Instead of belonging to the eliptic curve type or to a common Edwards > curve type, ED448 and ED25519 have each their own type. > > Also, OpenSSL excepts singatures

[Openvpn-devel] [PATCH] doc: fix literal block in tls-options.rst

Signed-off-by: Heiko Hund --- doc/man-sections/tls-options.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/man-sections/tls-options.rst b/doc/man-sections/tls-options.rst index c06ee335..d51aff77 100644 --- a/doc/man-sections/tls-options.rst +++ b/doc/man-sections/

Re: [Openvpn-devel] [PATCH v3 26/28] Allow setting control channel packet size with tls-mtu

> Arne Schwabe hat am 11.05.2022 13:08 geschrieben: > > > Currently control packet size is controlled by tun-mtu in a very > non-obvious way since the control overhead is not taken into account > and control channel packet will end up with a different size than > data channel packet. > > In

[Openvpn-devel] [PATCH v3 26/28] Allow setting control channel packet size with tls-mtu

Currently control packet size is controlled by tun-mtu in a very non-obvious way since the control overhead is not taken into account and control channel packet will end up with a different size than data channel packet. Instead we decouple this and introduce tls-mtu which defaults to 1250. Patch

[Openvpn-devel] Summary of the community meeting (11th May 2022)

Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on libera.chat Date: Wed 11th May 2022 Time: 10:30 CEST (9:30 UTC) Planned meeting topics for this meeting were here: Your local meeting ti

Re: [Openvpn-devel] [PATCH 27/28] Add unit test for reliable_get_num_output_sequenced_available

Acked-By: Frank Lichtenheld Not sure whether it should be concerning that reliable_get_num_output_sequenced_available is happy to give results given the complete garbage we put into the test buffer. But anyway, an UT is better than no UT and the test code looks correct to me. Obviously depends

Re: [Openvpn-devel] [PATCH v2 26/28] Allow setting control channel packet size with tls-mtu

> Arne Schwabe hat am 10.05.2022 19:07 geschrieben: [...] > diff --git a/Changes.rst b/Changes.rst > index 67a23c792..f40fc09ae 100644 > --- a/Changes.rst > +++ b/Changes.rst > @@ -79,6 +79,12 @@ Cookie based handshake for UDP server > shake. The tls-crypt-v2 option allows controlling if olde

Re: [Openvpn-devel] [PATCH v2 25/28] Ensure that control channel packet are respecting tls-mtu

Typo/grammar fixes only for now. > Arne Schwabe hat am 10.05.2022 19:04 geschrieben: > This ensure that control packets are actually smaller than tls-mtu. "ensures" > Since OpenVPN will consider a control message packet complete > when the TLS record is complete, we have to ensure that the SSL

Re: [Openvpn-devel] [PATCH] Implement --mtu-disc for IPv6 UDP sockets.

Am 22.02.22 um 15:35 schrieb Gert Doering: Commit 4225114b96 repaired "--mtu-disc yes" brokenness for IPv4 UDP sockets (caused by autoconf/ifdef issues). This patch adds new functionality to do --mtu-disc for IPv6 sockets as well. Half of it (setsockopt(IPV6_MTU_DISCOVER)) was already there, bu