[Openvpn-devel] [PATCH applied] Re: msvc: adjust build options to harden binaries

2022-03-17 Thread Gert Doering
.. and more magic XML files... :-) Your patch has been applied to the release/2.5 branch. commit 4bf8f1147dc7aadce2b15b84bb4613d965660191 Author: Lev Stipakov Date: Sat Feb 19 01:52:55 2022 +0200 msvc: adjust build options to harden binaries Signed-off-by: Lev Stipakov Acked-b

[Openvpn-devel] [PATCH applied] Re: vcpkg-ports: remove openssl port

2022-03-17 Thread Gert Doering
Acked-by: Gert Doering As discussed :-) Your patch has been applied to the release/2.5 branch. commit aa6f15dd2a1df68409384d6f955f68692595b77b (release/2.5) Author: Lev Stipakov Date: Thu Mar 17 15:57:28 2022 +0200 vcpkg-ports: remove openssl port Signed-off-by: Lev Stipakov

[Openvpn-devel] [PATCH release/2.5] vcpkg-ports: remove openssl port

2022-03-17 Thread Lev Stipakov
From: Lev Stipakov We've added functionality to openvpn-build f83f21ef "windows-msi: add ability to specify port overlays in openvpn-build" (which is used for release building) to use overlay ports, which enables us to build releases with updated ports (like openssl) without making changes

[Openvpn-devel] [PATCH applied] Re: msvc: adjust build options to harden binaries

2022-03-17 Thread Gert Doering
.. and more magic XML files... :-) Your patch has been applied to the release/2.5 branch. commit 4bf8f1147dc7aadce2b15b84bb4613d965660191 Author: Lev Stipakov Date: Sat Feb 19 01:52:55 2022 +0200 msvc: adjust build options to harden binaries Signed-off-by: Lev Stipakov Acked-b

[Openvpn-devel] [PATCH applied] Re: msvc: adjust build options to harden binaries

2022-03-17 Thread Gert Doering
Lots of magic XML... only actual code change is #pragma Your patch has been applied to the master branch. commit 2612125d7cf5e3c8687a3fab8fba61670ac12f35 Author: Lev Stipakov Date: Sat Feb 19 01:50:04 2022 +0200 msvc: adjust build options to harden binaries Signed-off-by: Lev Stipak

Re: [Openvpn-devel] [PATCH applied] Re: tapctl: Resolve MSVC C4996 warnings

2022-03-17 Thread Gert Doering
Hi, On Mon, Mar 22, 2021 at 10:17:17AM +0100, Gert Doering wrote: > My local tree was in a slightly funny state (the tip commit had a new > ID due to an accidential "git commit --amend" on the wrong head), so > I had to rebase and this commit got a new ID > > commit e5e9a07e8baee4065b7dfd65736bfa

[Openvpn-devel] [PATCH applied] Re: vcpkg-ports\openssl3: update to 3.0.2

2022-03-17 Thread Gert Doering
Acked-by: Gert Doering "looks reasonable" Your patch has been applied to the master branch. commit b0ee7d5789744f3ebcafa9f34f0563cca50d3a98 Author: Lev Stipakov Date: Thu Mar 17 14:23:57 2022 +0200 vcpkg-ports\openssl3: update to 3.0.2 Signed-off-by: Lev Stipakov Acked-by: G

[Openvpn-devel] [PATCH applied] Re: Fix incorrect default mssfix value in server mode

2022-03-17 Thread Gert Doering
Thanks for the band-aid :-) - I have not tested this, trusting you and Arne to have sufficiently tested this in the context of Win-DCO MSS handling (as a side note, patches against a tree with "dco_enabled(o)" in their context do not fit "master without DCO" easily ;-) ). Your patch has been appli

Re: [Openvpn-devel] [PATCH] add support for --dns option

2022-03-17 Thread Heiko Hund
Hi Gert On Donnerstag, 17. März 2022 11:41:22 CET Gert Doering wrote: > I wonder why we bother to actually *do* this? As in "we already know > that this can never overflow here" (because all strings involved are > known, and the max width of %d is known, too), but *if* it ever did, > calling the

[Openvpn-devel] [PATCH applied] Re: networking: use OPENVPN_ETH_ALEN instead of ETH_ALEN

2022-03-17 Thread Gert Doering
Acked-by: Gert Doering Change makes sense, brings no behavioural change. Your patch has been applied to the master and release/2.5 branch. commit 8d487b4cc5b896cff5277adef6dd491b5918381f (master) commit 445cc852727a59f7338e59f0e594714d2b722beb (HEAD -> release/2.5) Author: Antonio Quartulli Dat

[Openvpn-devel] [PATCH] vcpkg-ports\openssl3: update to 3.0.2

2022-03-17 Thread Lev Stipakov
From: Lev Stipakov While on it, remove deprecated vcpkg_fail_port_install(). since we don't care about UWP/Linux/OS X here. Also bump github actions's vcpkg commit id. Signed-off-by: Lev Stipakov --- .github/workflows/build.yaml| 2 +- contrib/vcpkg-ports/openssl3/portfile.cma

[Openvpn-devel] [PATCH applied] Re: options: drop useless netmask variable

2022-03-17 Thread Gert Doering
Acked-by: Gert Doering Trivial change, obviously correct. I *did* test-compile this :-) but did not actually test any iroute stuff (that will come next in the "DCO server" testbed). Your patch has been applied to the master branch. commit 07be493796250ad680a4a41c26e19c1938bf37ce Author: Anton

Re: [Openvpn-devel] [PATCH applied] Re: vcpkg-ports: add openssl 1.1.1n

2022-03-17 Thread Gert Doering
Hi, On Wed, Mar 16, 2022 at 10:29:37AM +0100, Frank Lichtenheld wrote: > > As discussed on IRC, we need to build with the new security-fixed 1.1.1n > > release, and vcpkg port is not there yet. Somewhat annoying, we should > > find a better way to decouple "build" and "openvpn main repo" commits

Re: [Openvpn-devel] [PATCH] add support for --dns option

2022-03-17 Thread Gert Doering
Hi, (this is about v2) On Sat, Mar 12, 2022 at 02:58:10PM +0100, Heiko Hund wrote: > As a first step towards DNS configuration in openvpn and a unified way > to push DNS related settings to clients in v2 and v3, this commit adds > support for parsing the new --dns option. Later commits will add s

[Openvpn-devel] [PATCH applied] Re: vcpkg-ports\pkcs11-helper: shorten patch filename

2022-03-17 Thread Gert Doering
Acked-by: Gert Doering Tested on "master" and "release/2.5", make dist now proceeds without error, and the file is contained in the tarball. "tar" changed to "tar -o", makes sense. Your patch has been applied to the master and release/2.5 branch. commit 2047522286f179cac09bd7615bf845d67a5dc1c8

Re: [Openvpn-devel] [PATCH master+release/2.5] vcpkg-ports\pkcs11-helper: shorten patch filename

2022-03-17 Thread Lev Stipakov
This is something which Gert could fix on commit, I think? ke 16. maalisk. 2022 klo 19.22 Frank Lichtenheld (fr...@lichtenheld.com) kirjoitti: > > > > Lev Stipakov hat am 16.03.2022 14:54 geschrieben: > > > > > > From: Lev Stipakov > > > > "make dist" uses tar which breaks on long filenames: >