Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-20 Thread Gert Doering
Hi, On Sun, Feb 20, 2022 at 07:53:56PM +0500, ?? wrote: > There is ack from me earlier in this thread. "ACK in this thread" is not really helpful, as it is not clear for which patch exactly this is. (You basically ACKed in response to v1 of the 2.5 patch, while we have v2 fo

Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-20 Thread Илья Шипицин
There is ack from me earlier in this thread. Lev, I did all things you asked me to do. Please follow up. I do not catch what else left On Sun, Feb 20, 2022, 7:38 PM Gert Doering wrote: > Hi, > > On Sun, Feb 20, 2022 at 07:29:24PM +0500, ?? wrote: > > Lev, I'm lost here. Can

Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-20 Thread Gert Doering
Hi, On Sun, Feb 20, 2022 at 07:29:24PM +0500, ?? wrote: > Lev, I'm lost here. Can you please follow up? Please test and ACK *this* patch: https://patchwork.openvpn.net/patch/2296/ this is the "v2 for master" patch. When that is done, we can talk about release/2.5 appli

[Openvpn-devel] [PATCH applied] Re: openvpnmsica: add ovpn-dco custom actions

2022-02-20 Thread Gert Doering
Acked-by: Gert Doering Thanks to Simon for testing & advising Lev here. I would have preferred to have the WCHAR fixes decoupled from "new functionality" - that makes reviewing easier. This said, the WCHAR fixes look good, and the rest looks at least "reasonable" - as I have no much idea what's

Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-20 Thread Илья Шипицин
Lev, I'm lost here. Can you please follow up? On Sun, Feb 20, 2022, 7:18 PM Gert Doering wrote: > Hi, > > On Sun, Feb 20, 2022 at 07:15:33PM +0500, ?? wrote: > > It is applied to master. > > The "adjust build options to harden binaries" has no ACK for master. > > This is nee

Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-20 Thread Gert Doering
Hi, On Sun, Feb 20, 2022 at 07:15:33PM +0500, ?? wrote: > It is applied to master. The "adjust build options to harden binaries" has no ACK for master. This is needed so the 2.5 patch can go into 2.5 gert -- "If was one thing all people took for granted, was conviction tha

Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-20 Thread Илья Шипицин
It is applied to master. git id: https://github.com/OpenVPN/openvpn/commit/9da733751ce80b2226ef19923365bd3102cfbd47 On Sun, Feb 20, 2022, 7:10 PM Gert Doering wrote: > Hi, > > On Sun, Feb 20, 2022 at 07:07:15PM +0500, ?? wrote: > > pdb patch > > Whatever that is... a commit

Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-20 Thread Gert Doering
Hi, On Sun, Feb 20, 2022 at 07:07:15PM +0500, ?? wrote: > pdb patch Whatever that is... a commit ID in master would be much easier for me to cherrypick. (In any case, *this* patch can't go into 2.5 before the *master* patch has an ACK - for patches for "master + 2.5", master

[Openvpn-devel] [PATCH applied] Re: crypto: unify key_type creation code

2022-02-20 Thread Gert Doering
Acked-by: Gert Doering Patch looks good, "make check" passes again :-) Your patch has been applied to the master branch. commit 2e7ec64fc40cb5d184fd5c47c875ce381ca1b8d3 Author: Antonio Quartulli Date: Thu Feb 17 17:31:59 2022 +0100 crypto: unify key_type creation code Signed-off-b

Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-20 Thread Илья Шипицин
pdb patch On Sun, Feb 20, 2022, 7:04 PM Gert Doering wrote: > Hi, > > On Thu, Feb 17, 2022 at 01:55:35PM +0200, Lev Stipakov wrote: > > > can you please apply "pdb" patch to your branch ? > > > CI: github actions: keep "pdb" in artifacts · OpenVPN/openvpn@9da7337 > > > > Done! https://github.com

Re: [Openvpn-devel] [Patch v2] Add warning about mbed TLS licensing problem

2022-02-20 Thread Gert Doering
Hi, On Wed, Feb 16, 2022 at 05:51:02PM +0100, Frank Lichtenheld wrote: > > Max Fillinger hat am 16.02.2022 15:04 > > geschrieben: > > > > Signed-off-by: Max Fillinger > > --- > > README.mbedtls | 17 + > > 1 file changed, 17 insertions(+) > > Might be good to also add a note

Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-20 Thread Gert Doering
Hi, On Thu, Feb 17, 2022 at 01:55:35PM +0200, Lev Stipakov wrote: > > can you please apply "pdb" patch to your branch ? > > CI: github actions: keep "pdb" in artifacts · OpenVPN/openvpn@9da7337 > > Done! https://github.com/lstipakov/openvpn/actions/runs/1858390624 > > > BinSkim uses pdb for anal