Re: [Openvpn-devel] [PATCH 2.5] msvc: adjust build options to harden binaries

2022-02-16 Thread Илья Шипицин
original patch does not apply C:\i\openvpn-chipitsine-2.5>"C:\Program Files\Git\usr\bin\patch.exe" -p1 < c:\users\ilia\Downloads\Openvpn-devel-2.5-msvc-adjust-build-options-to-harden-binaries.diff patching file src/openvpn/openvpn.vcxproj Hunk #1 FAILED at 147. Hunk #2 FAILED at 162. Hunk #3 FAILE

Re: [Openvpn-devel] [Patch v2] Add warning about mbed TLS licensing problem

2022-02-16 Thread Frank Lichtenheld
> Max Fillinger hat am 16.02.2022 15:04 > geschrieben: > > > Signed-off-by: Max Fillinger > --- > README.mbedtls | 17 + > 1 file changed, 17 insertions(+) Might be good to also add a note in the "Deprecated Features" section of Changes.rst? Just to increase visibility.

Re: [Openvpn-devel] [PATCH] Add warning about mbed TLS licensing problem

2022-02-16 Thread Gert Doering
Hi, On Wed, Feb 16, 2022 at 07:45:20PM +0500, ?? wrote: > +Support for mbed TLS is likely to be removed in OpenVPN 2.17. We have a very long-term planning horizon these days! gert -- "If was one thing all people took for granted, was conviction that if you feed honest fi

Re: [Openvpn-devel] [PATCH] Add warning about mbed TLS licensing problem

2022-02-16 Thread Илья Шипицин
+Support for mbed TLS is likely to be removed in OpenVPN 2.17. 2.7 ? ср, 16 февр. 2022 г. в 19:13, Max Fillinger < maximilian.fillin...@foxcrypto.com>: > Signed-off-by: Max Fillinger > --- > README.mbedtls | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/README.mbedt

[Openvpn-devel] [Patch v2] Add warning about mbed TLS licensing problem

2022-02-16 Thread Max Fillinger
Signed-off-by: Max Fillinger --- README.mbedtls | 17 + 1 file changed, 17 insertions(+) diff --git a/README.mbedtls b/README.mbedtls index 4875822d..062ae470 100644 --- a/README.mbedtls +++ b/README.mbedtls @@ -11,6 +11,23 @@ This version depends on mbed TLS 2.0 (and requires at

[Openvpn-devel] [PATCH] Add warning about mbed TLS licensing problem

2022-02-16 Thread Max Fillinger
Signed-off-by: Max Fillinger --- README.mbedtls | 17 + 1 file changed, 17 insertions(+) diff --git a/README.mbedtls b/README.mbedtls index 4875822d..b5604bb8 100644 --- a/README.mbedtls +++ b/README.mbedtls @@ -11,6 +11,23 @@ This version depends on mbed TLS 2.0 (and requires at

[Openvpn-devel] [PATCH master+release/2.5] vcpkg: link lzo statically

2022-02-16 Thread Lev Stipakov
From: Lev Stipakov Having .dll for a single executable doesn't make much sense. Static linking removes 117kb .dll and grows .exe size by only 4kb. Signed-off-by: Lev Stipakov --- contrib/vcpkg-triplets/arm64-windows-ovpn.cmake | 3 ++- contrib/vcpkg-triplets/x64-windows-ovpn.cmake | 3 ++- c

[Openvpn-devel] [PATCH applied] Re: Fix mbed TLS compile if OpenSSL headers are not available

2022-02-16 Thread Gert Doering
Acked-by: Gert Doering "Because it makes sense" :-) - ignoring the "core_dispatnch.h" typo. Your patch has been applied to the master branch. commit e8a2794824ded011a1ed58aeb95321332b1ae684 Author: Arne Schwabe Date: Wed Feb 16 13:56:53 2022 +0100 Fix mbed TLS compile if OpenSSL headers

[Openvpn-devel] [PATCH applied] Re: doc/options: clean up documentation for --proto and related options

2022-02-16 Thread Gert Doering
Your patch has been applied to the master and release/2.5 branch (applied without resistance, documentation improvements are good). commit ba9a07a69db3ddb63fceac05b92a000d9b1c805e (master) commit 1e177d87f968be14f14b293273039c522ed1a75f (release/2.5) Author: Frank Lichtenheld Date: Tue Feb 15 15

[Openvpn-devel] [PATCH] Fix mbed TLS compile if OpenSSL headers are not available

2022-02-16 Thread Arne Schwabe
We unconditionally include openssl/opensslv.h which fails if OpenSSL header are not available. Signed-off-by: Arne Schwabe --- src/openvpn/xkey_common.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/openvpn/xkey_common.h b/src/openvpn/xkey_common.h index e58748b4.

[Openvpn-devel] Summary of the community meeting (16th February 2021)

2022-02-16 Thread Samuli Seppänen
Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on libera.chat Date: Wed 16th February 2022 Time: 10:30 CET (9:30 UTC) Planned meeting topics for this meeting were here: Your local meeti

Re: [Openvpn-devel] [PATCH 3/3 v3] doc/options: clean up documentation for --proto and related options

2022-02-16 Thread David Sommerseth
On 15/02/2022 15:54, Frank Lichtenheld wrote: The family specific options were generally omitted. Cc: David Sommerseth Signed-off-by: Frank Lichtenheld --- doc/man-sections/client-options.rst | 10 ++ doc/man-sections/link-options.rst | 5 - src/openvpn/options.c

Re: [Openvpn-devel] [PATCH] Fix checks of SHA256 in tls-crypt and auth-token

2022-02-16 Thread Gert Doering
Hi, On Tue, Feb 15, 2022 at 11:54:07AM +0100, Arne Schwabe wrote: > These checks were not correctly updated. The check in auth-token > did nothing at all and the check in tls-crypt was the wrong check > but that was hidden by the condition being inverted as well. For the sake of the archives: Ant

[Openvpn-devel] [PATCH applied] Re: auth_token/tls_crypt: fix usage of md_valid()

2022-02-16 Thread Gert Doering
Stared at code (looks good). Tested with Richard's config (no more warnings about SHA256, good), and ran my usual set of client tests (no issues). I did notice a long standing copy-paste thing in auth_token.c... msg(M_WARN, "ERROR: --tls-crypt requires HMAC-SHA-256 support."); .. this