[Openvpn-devel] [PATCH applied] Re: doc: fix misc documentation issues

2022-02-15 Thread Gert Doering
Your patch has been applied to the master branch. commit fe340a9c1ee1b04b17e7fb367043ff575763b91c Author: Frank Lichtenheld Date: Mon Feb 14 18:33:42 2022 +0100 doc: fix misc documentation issues Signed-off-by: Frank Lichtenheld Acked-by: David Sommerseth Message-Id: <202

[Openvpn-devel] [PATCH 3/3 v3] doc/options: clean up documentation for --proto and related options

2022-02-15 Thread Frank Lichtenheld
The family specific options were generally omitted. Cc: David Sommerseth Signed-off-by: Frank Lichtenheld --- doc/man-sections/client-options.rst | 10 ++ doc/man-sections/link-options.rst | 5 - src/openvpn/options.c | 17 + 3 files changed, 23 inse

Re: [Openvpn-devel] [PATCH] Fix checks of SHA256 in tls-crypt and auth-token

2022-02-15 Thread tincantech via Openvpn-devel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 May as well attribute this correctly. * tincant...@protonmail.com Protonmail, now so badly mangles mail on reply that I may have to go back to gmail. -BEGIN PGP SIGNATURE- Version: ProtonMail wsBzBAEBCAAGBQJiC7VvACEJEE+XnPZrkLidFiEECbw9RG

Re: [Openvpn-devel] [PATCH 2/3 v2] doc: fix misc documentation issues

2022-02-15 Thread David Sommerseth
On 14/02/2022 18:33, Frank Lichtenheld wrote: - Broken/missing formatting - Make it obvious which arguments are optional Only the files touched have been reviewed, all other files likely have similar issues. Signed-off-by: Frank Lichtenheld --- doc/man-sections/client-options.rst | 4 ++--

Re: [Openvpn-devel] [PATCH 3/3 v2] doc/options: clean up documentation for --proto and related options

2022-02-15 Thread David Sommerseth
On 14/02/2022 13:41, Frank Lichtenheld wrote: David Sommerseth hat am 11.02.2022 21:39 geschrieben: On 10/02/2022 11:21, Frank Lichtenheld wrote: The family specific options were generally omitted. Signed-off-by: Frank Lichtenheld --- doc/man-sections/client-options.rst | 5 +

Re: [Openvpn-devel] [PATCH v2] auth_token/tls_crypt: fix usage of md_valid()

2022-02-15 Thread Arne Schwabe
Am 15.02.22 um 13:31 schrieb Antonio Quartulli: With b39725cf ("Remove md_kt_t and change crypto API to use const char*") the logic for validating ciphers and md algorithms has been changed. We should now *always* use md_valid() when validating a digest alg. At the same time, add '!' (negation)

[Openvpn-devel] [PATCH v2] auth_token/tls_crypt: fix usage of md_valid()

2022-02-15 Thread Antonio Quartulli
With b39725cf ("Remove md_kt_t and change crypto API to use const char*") the logic for validating ciphers and md algorithms has been changed. We should now *always* use md_valid() when validating a digest alg. At the same time, add '!' (negation) when validating the digest algorithm in the tls-c

Re: [Openvpn-devel] [PATCH] auth_token/tls_crypt: fix usage of md_valid()

2022-02-15 Thread Arne Schwabe
Am 15.02.22 um 11:26 schrieb Antonio Quartulli: With b39725cf ("Remove md_kt_t and change crypto API to use const char*") the logic for validating ciphers and md algorithms has been changed. We should now *always* use md_valid() when validating a digest alg. At the same time, add '!' (negation)

[Openvpn-devel] [PATCH] Fix checks of SHA256 in tls-crypt and auth-token

2022-02-15 Thread Arne Schwabe
These checks were not correctly updated. The check in auth-token did nothing at all and the check in tls-crypt was the wrong check but that was hidden by the condition being inverted as well. Reported-By: tincnt...@protonmail.com --- src/openvpn/auth_token.c | 2 +- src/openvpn/crypto_backend

[Openvpn-devel] [PATCH] auth_token/tls_crypt: fix usage of md_valid()

2022-02-15 Thread Antonio Quartulli
With b39725cf ("Remove md_kt_t and change crypto API to use const char*") the logic for validating ciphers and md algorithms has been changed. We should now *always* use md_valid() when validating a digest alg. At the same time, add '!' (negation) when validating the digest algorithm in the tls-c