[Openvpn-devel] [PATCH] Add argv_insert_head__empty_argv__head_only to argv tests

2021-12-08 Thread Arne Schwabe
The unit test argv_insert_head__empty_argv__head_only was defined but never used. Add it to the array of unit tests. Signed-off-by: Arne Schwabe --- tests/unit_tests/openvpn/test_argv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit_tests/openvpn/test_argv.c b/tests/unit_tests/o

[Openvpn-devel] Summary of the community meeting (8th December 2021)

2021-12-08 Thread Samuli Seppänen
Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on libera.chat Date: Wed 8th December 2021 Time: 14:00 CET (12:00 UTC) Planned meeting topics for this meeting were here: Your local meetin

[Openvpn-devel] [PATCH applied] Re: Define have_blowfish variable in ncp unit tests

2021-12-08 Thread Gert Doering
Acked-by: Gert Doering Thanks for quickly fixing my oversight :-) - and yes, *this* time, I have actually tested the resulting build. Both with openssl and mbed. Your patch has been applied to the release/2.5 branch. commit 39f50f58b7b73502a593c4beda3af947bcac (release/2.5) Author: Max Fil

[Openvpn-devel] [PATCH 2.5] Define have_blowfish variable in ncp unit tests

2021-12-08 Thread Max Fillinger
The previous commit was backported from master and needs this variable to exist. Signed-off-by: Max Fillinger --- tests/unit_tests/openvpn/test_ncp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/unit_tests/openvpn/test_ncp.c b/tests/unit_tests/openvpn/test_ncp.c i

[Openvpn-devel] [PATCH applied] Re: Don't use BF-CBC in unit tests if we don't have it

2021-12-08 Thread Gert Doering
Acked-by: Gert Doering I do not have a "non blowfish" mbedtls to test with, but the fix is "obviously correct", as discussed on IRC. Your patch has been applied to the master + release/2.5 branch (bugfix). commit 0e075c0e1b7b1d55a837d98b7a6c2bc8c7d65375 (master) commit 57820e8bb1eca8e9e08df0032

[Openvpn-devel] [PATCH] Don't use BF-CBC in unit tests if we don't have it

2021-12-08 Thread Max Fillinger
Signed-off-by: Max Fillinger --- tests/unit_tests/openvpn/test_ncp.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/unit_tests/openvpn/test_ncp.c b/tests/unit_tests/openvpn/test_ncp.c index 6702133a..f4c28ffd 100644 --- a/tests/unit_tests/openvpn/test_ncp.c +++