Re: [Openvpn-devel] [PATCH 7/7] add message about changing default values

2021-09-13 Thread Selva Nair
Hi On Mon, Sep 13, 2021 at 3:23 PM Antonio Quartulli wrote: > Hi, > > On 13/09/2021 18:51, Selva Nair wrote: > > Hi > > > > On Mon, Sep 13, 2021 at 10:22 AM Jonathan K. Bullard > > mailto:jkbull...@gmail.com>> wrote: > > > > Hi, > > > > On Mon, Sep 13, 2021 at 8:37 AM Gert Doering >

[Openvpn-devel] [PATCH v2 6/7] set TLS 1.2 as minimum by default

2021-09-13 Thread Antonio Quartulli
Do not accept handshakes with peers trying to negotiate TLS lower than 1.2. TLS 1.1 and 1.0 are not recommended and therefore will, by default, allow TLS 1.2 as minimum version. The minimum allowed version can still be controlled via '--tls-version-min'. At the same time automatically set '--tls-

Re: [Openvpn-devel] [PATCH 7/7] add message about changing default values

2021-09-13 Thread Antonio Quartulli
Hi, On 13/09/2021 18:51, Selva Nair wrote: > Hi > > On Mon, Sep 13, 2021 at 10:22 AM Jonathan K. Bullard > mailto:jkbull...@gmail.com>> wrote: > > Hi, > > On Mon, Sep 13, 2021 at 8:37 AM Gert Doering > wrote: > > > > Hi, > > > > On Sat, S

Re: [Openvpn-devel] [PATCH 6/7] set TLS 1.2 as minimum by default

2021-09-13 Thread Antonio Quartulli
Hi, On 13/09/2021 14:39, Gert Doering wrote: > Hi, > > On Sat, Sep 04, 2021 at 11:56:28AM +0200, Antonio Quartulli wrote: >> diff --git a/src/openvpn/options.c b/src/openvpn/options.c >> index f2fb6d64..6f6eb73d 100644 >> --- a/src/openvpn/options.c >> +++ b/src/openvpn/options.c >> @@ -850,6 +85

Re: [Openvpn-devel] [PATCH 7/7] add message about changing default values

2021-09-13 Thread Selva Nair
Hi On Mon, Sep 13, 2021 at 10:22 AM Jonathan K. Bullard wrote: > Hi, > > On Mon, Sep 13, 2021 at 8:37 AM Gert Doering wrote: > > > > Hi, > > > > On Sat, Sep 04, 2021 at 11:56:29AM +0200, Antonio Quartulli wrote: > > > Add warning at startup to notify users about the change. > > [..] > > > +

[Openvpn-devel] [PATCH] multi: remove extra brackets in multi_process_incoming_link()

2021-09-13 Thread Antonio Quartulli
After getting rid of all PF related ifdef blocks, a pair of useless brackets has remained in multi_process_incoming_link(). These brackets do nothing at the moment and can be just removed. Signed-off-by: Antonio Quartulli --- src/openvpn/multi.c | 6 ++ 1 file changed, 2 insertions(+), 4 del

Re: [Openvpn-devel] [PATCH 7/7] add message about changing default values

2021-09-13 Thread Jonathan K. Bullard
Hi, On Mon, Sep 13, 2021 at 8:37 AM Gert Doering wrote: > > Hi, > > On Sat, Sep 04, 2021 at 11:56:29AM +0200, Antonio Quartulli wrote: > > Add warning at startup to notify users about the change. > [..] > > +/* Give a general warning at the end of initialisation that defaults > > + * have

Re: [Openvpn-devel] [PATCH 6/7] set TLS 1.2 as minimum by default

2021-09-13 Thread Gert Doering
Hi, On Sat, Sep 04, 2021 at 11:56:28AM +0200, Antonio Quartulli wrote: > diff --git a/src/openvpn/options.c b/src/openvpn/options.c > index f2fb6d64..6f6eb73d 100644 > --- a/src/openvpn/options.c > +++ b/src/openvpn/options.c > @@ -850,6 +850,7 @@ init_options(struct options *o, const bool init_gc

Re: [Openvpn-devel] [PATCH 7/7] add message about changing default values

2021-09-13 Thread Gert Doering
Hi, On Sat, Sep 04, 2021 at 11:56:29AM +0200, Antonio Quartulli wrote: > Add warning at startup to notify users about the change. [..] > +/* Give a general warning at the end of initialisation that defaults > + * have changed */ > +msg(M_WARN, "Note that modernisation of defaults in Op

Re: [Openvpn-devel] [PATCH 1/2] networking: add and implement net_addr_ll_set() API

2021-09-13 Thread Gert Doering
HI, On Fri, Sep 03, 2021 at 06:11:12PM +0200, Antonio Quartulli wrote: > Reported-by: Jan Hugo Prins Jan Hugo, have you been able to test these two patches? I could set up a test rig myself, but since I do not experience the issue, it's always more useful if an affected user reports "yes, it wo

[Openvpn-devel] [PATCH applied] Re: configure: search also for rst2{man, html}.py

2021-09-13 Thread Gert Doering
Acked-by: Gert Doering Tested on my gentoo system, which had symlinks rst2html -> rst2html.py (etc) previously, to work around our configure inflexibility. This now becomes... .. checking for rst2man... no checking for rst2man.py... rst2man.py checking for rst2html... no checking for rst2html.