Re: [Openvpn-devel] [PATCH v2 9/9] Support NCP in pure P2P VPN setups

2021-07-19 Thread Antonio Quartulli
Hi, This patch does not apply on top of master + v6-cleanup + 8/9 Can you rebase it? or maybe you you can point me to some commit in your branch that I can pull for now? Cheers, -- Antonio Quartulli ___ Openvpn-devel mailing list Openvpn-devel@list

Re: [Openvpn-devel] [PATCH v2 8/9] Remove --ncp-disable option

2021-07-19 Thread Antonio Quartulli
Hi, On 20/05/2021 17:11, Arne Schwabe wrote: > NCP has proven to be stable and apart from the one VPN Provider doing > hacky things with homebrewed NCP we have not had any reports about > ncp-disable being required. Remove ncp-disable to simplify code paths. > > Note: This patch breaks client wit

Re: [Openvpn-devel] [PATCH v6] Cleanup handling of initial auth token

2021-07-19 Thread Antonio Quartulli
Hi, On 19/07/2021 15:31, Arne Schwabe wrote: > This changes that auth_token_initial is set when the token is > initially generated instead when pushing the token. Even I do not know > anymore why I did it in this way in the first place. Also use > multi->auth_token_initial as source for the sesssi

Re: [Openvpn-devel] [PATCH] Fix leaks in route.

2021-07-19 Thread david korczynski
Sounds good, and the rule of committing code sounds good to me! I will be looking to providing more patches based on what the fuzzing finds in the near future. On 19/07/2021 17:11, Gert Doering wrote: ADA Logics Ltd is registered in England. No: 11624074. Registered office: 266 Banbury Road, Pos

Re: [Openvpn-devel] [PATCH] Fix leaks in route.

2021-07-19 Thread Gert Doering
Hi, On Mon, Jul 19, 2021 at 04:29:32PM +0100, david korczynski wrote: > Gert and Antonio, I am not sure if you would want me to change the > commit message or not. Let me know if you want me to change it and then > I will do that. Nah, I'll adjust the commit message when commiting. (Our rule is:

Re: [Openvpn-devel] [PATCH] Fix leaks in route.

2021-07-19 Thread david korczynski
Gert and Antonio, I am not sure if you would want me to change the commit message or not. Let me know if you want me to change it and then I will do that. On 15/07/2021 10:10, Gert Doering wrote: ADA Logics Ltd is registered in England. No: 11624074. Registered office: 266 Banbury Road, Post Box

[Openvpn-devel] [PATCH v6] Cleanup handling of initial auth token

2021-07-19 Thread Arne Schwabe
This changes that auth_token_initial is set when the token is initially generated instead when pushing the token. Even I do not know anymore why I did it in this way in the first place. Also use multi->auth_token_initial as source for the sesssion ID since it should now always be available. Also se

Re: [Openvpn-devel] [PATCH v5] Cleanup handling of initial auth token

2021-07-19 Thread Arne Schwabe
>> /* >> * reuse the same session id and timestamp and null terminate it at >> * for base64 decode it only decodes the session id part of it >> */ > > This comment above does not make much sense to me, but since it has been > there since "ever", I'd suggest