Re: [Openvpn-devel] [PATCH v3 7/9] Cleanup handling of initial auth token

2021-07-06 Thread tincantech via Openvpn-devel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, this is a comment about a comment which this patch is not changing but the comment is so awful I thought it best to make a note. See below. Also, two typos. And FYI, 'anymore' ought to be 'any more' R Sent with ProtonMail Secure Email, which

[Openvpn-devel] [PATCH v3 7/9] Cleanup handling of initial auth token

2021-07-06 Thread Arne Schwabe
This changes that auth_token_initial is set when the token is initially generated instead when pushing the token. Even I do not know anymore why I did it in this way in the first place. Also use multi->auth_token_initial as source for the sesssion ID since it should now always be available. Since

Re: [Openvpn-devel] [PATCH v3 6/9] Introduce S_GENERATED_KEYS state and generate keys only when authenticated

2021-07-06 Thread Antonio Quartulli
Hi, On 05/07/2021 15:34, Arne Schwabe wrote: > Since generating data channel keys does not happen when we have reach the > S_ACTIVE/S_GOT_KEY state anymore like it used to be before NCP, the > state that data channel keys deserves its own state in the TLS session > state machine. > > The changes

[Openvpn-devel] Community meetings in July 2021

2021-07-06 Thread Samuli Seppänen
Hi, Next community meetings have been scheduled to - Wed 7th July 2021 at 14:00 CET - Wed 14th July 2021 at 14:00 CET - Wed 21st July 2021 at 14:00 CET - Wed 28th July 2021 at 14:00 CET The place is #openvpn-meeting IRC channel at libera.chat Meeting agendas and summaries are in here: