Acked-by: Gert Doering
Thanks. Seems someone from the core team really loves this function!
Your patch has been applied to the master branch.
For the next patch, please take care of a few things
- do the git commit with "-s", to get the "signed-off-by:" line
- your git setup is missing a co
---
src/openvpn/crypto_backend.h | 12
1 file changed, 12 deletions(-)
diff --git a/src/openvpn/crypto_backend.h b/src/openvpn/crypto_backend.h
index 35cd918..af123d0 100644
--- a/src/openvpn/crypto_backend.h
+++ b/src/openvpn/crypto_backend.h
@@ -88,18 +88,6 @@ void crypto_init_dmal
Acked-by: Gert Doering
Yeah, windows... sorry for breaking MSVC again, thanks for fixing
the typo :-) - only compile-tested on FreeBSD.
(Adding Selva's ACK on v1, for good measure)
Your patch has been applied to the master branch.
commit 88395a8307964ad48c3841c0b2fb60dce826ebf1
Author: Lev St
On Mon, Jun 7, 2021 at 2:56 PM Lev Stipakov wrote:
>
> From: Lev Stipakov
>
> Commit b7fe49c ("Do not require CA when peer-fingerprint is used") broke
> msvc build by adding #ifdef within msg() macro call.
>
> options.c(2074,1): error C2121: '#': invalid character: possibly the
> result of a
From: Lev Stipakov
Commit b7fe49c ("Do not require CA when peer-fingerprint is used") broke
msvc build by adding #ifdef within msg() macro call.
options.c(2074,1): error C2121: '#': invalid character: possibly the result
of a macro expansion
options.c(2074,1): error C2146: syntax error:
From: Lev Stipakov
Commit b7fe49c ("Do not require CA when peer-fingerprint is used") broke
msvc build by adding #ifdef within msg() macro call.
options.c(2074,1): error C2121: '#': invalid character: possibly the result
of a macro expansion
options.c(2074,1): error C2146: syntax error:
Hi
On Mon, Jun 7, 2021 at 3:34 AM Lev Stipakov wrote:
>
> Hi,
>
> > It has a long (6 years and counting) history and may never get merged...
> >
> > https://github.com/OpenSC/pkcs11-helper/pull/4
> >
> > We could look into incorporating it into our own pkcs11 glue code
> > (pkcs11.c etc.). Not s
From: Lev Stipakov
pkcs11-helper is a dependency library used by OpenVPN.
So far it has been built only by mingw.
Since we're making MSVC build system a first class citizen,
we need to build depencencies with MSVC, which we do with vcpkg.
All dependencies are in vcpkg official repo, expect pkcs1
Hey,
> Just for completeness - I assume that this is a v2 of the patch, and
> "something
> was changed". Since we're all very lazy^Wbusy people, it would be good to
> include a list of v2 changes in the commit message, like this:
sorry for that, too; I added the corresponding info to the amende
Hi,
On Fri, Jun 04, 2021 at 04:31:25PM +0200, Heiko Wundram wrote:
> The certificate selection process for the Crypto API certificates
> is currently fixed to match on subject or identifier. Especially
> if certificates that are used for OpenVPN are managed by a Windows CA,
[..]
Just for complete
Hi,
On Fri, Jun 04, 2021 at 05:33:25PM +0300, Lev Stipakov wrote:
> This can be applied to release/2.5 as well.
And so it has been done
commit 90770576baf4bd81545f19b531bae5fe37f69802 (HEAD -> release/2.5)
Author: Lev Stipakov
Date: Fri May 7 17:56:44 2021 +0300
msvc: add ARM64 configura
Hi,
On Mon, Jun 07, 2021 at 10:34:36AM +0300, Lev Stipakov wrote:
> 3) do nothing and have those ports as part of openvpn repo. vcpkg
> supports "ports-overlay" , so
> I see nothing wrong or "hacky" with this approach. I see you point
> about having dependencies build scripts
> as part of openvpn
Hi,
> It has a long (6 years and counting) history and may never get merged...
>
> https://github.com/OpenSC/pkcs11-helper/pull/4
>
> We could look into incorporating it into our own pkcs11 glue code
> (pkcs11.c etc.). Not sure whether it really needs access to any
> innards of pkcs11-helper.
So
13 matches
Mail list logo
