[Openvpn-devel] [PATCH v2] Ignore leading whitespace and comment lines for peer-fingerprint.

2021-05-18 Thread Gert Doering
Inline peer-fingerprint blocks can benefit from a bit of structuring by indentation or by putting comments ("# this is Alice's key"). v2: accept ';' and '#' as comment delimiter. Fix tab-indent. Signed-off-by: Gert Doering --- src/openvpn/options.c | 9 +++-- 1 file changed, 7 insertions(+

Re: [Openvpn-devel] [PATCH] Ignore leading whitespace and comment lines for peer-fingerprint.

2021-05-18 Thread Gert Doering
Hi, On Tue, May 18, 2021 at 07:23:44PM -0400, Selva Nair wrote: > > while ((line = strsep(&lines, "\n"))) > > { > > -/* skip empty lines */ > > -if (strlen(line) == 0) > > + /* ignore leading whitespace */ > > + while(isspace(*line)) > > + { > > +

[Openvpn-devel] [PATCH] Ignore leading whitespace and comment lines for peer-fingerprint.

2021-05-18 Thread Gert Doering
Inline peer-fingerprint blocks can benefit from a bit of structuring by indentation or by putting comments ("# this is Alice's key"). v2: accept ';' and '#' as comment delimiter. Fix tab-indent. Signed-off-by: Gert Doering --- src/openvpn/options.c | 9 +++-- 1 file changed, 7 insertions(+

Re: [Openvpn-devel] [PATCH] Ignore leading whitespace and comment lines for peer-fingerprint.

2021-05-18 Thread Selva Nair
Hi, On Tue, May 18, 2021 at 10:33 AM Gert Doering wrote: > > Inline peer-fingerprint blocks can benefit from a bit of structuring > by indentation or by putting comments ("# this is Alice's key"). > > Signed-off-by: Gert Doering > --- > src/openvpn/options.c | 9 +++-- > 1 file changed, 7 i

Re: [Openvpn-devel] [PATCH 9/9] Add detailed man page section to setup a OpenVPN setup with peer-fingerprint

2021-05-18 Thread tincantech via Openvpn-devel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, ‐‐‐ Original Message ‐‐‐ On Monday, 17 May 2021 20:07, tincantech wrote: > Hi, > > ‐‐‐ Original Message ‐‐‐ > On Monday, 17 May 2021 18:16, tincantech via Openvpn-devel > openvpn-devel@lists.sourceforge.net wrote: > > > Hi, >

[Openvpn-devel] [PATCH] Ignore leading whitespace and comment lines for peer-fingerprint.

2021-05-18 Thread Gert Doering
Inline peer-fingerprint blocks can benefit from a bit of structuring by indentation or by putting comments ("# this is Alice's key"). Signed-off-by: Gert Doering --- src/openvpn/options.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/openvpn/options.c b/src/ope

Re: [Openvpn-devel] [PATCH 9/9] Add detailed man page section to setup a OpenVPN setup with peer-fingerprint

2021-05-18 Thread tincantech via Openvpn-devel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, ‐‐‐ Original Message ‐‐‐ On Tuesday, 18 May 2021 13:21, Arne Schwabe wrote: > Am 17.05.21 um 19:16 schrieb tincantech: > > > Hi, > > ‐‐‐ Original Message ‐‐‐ > > On Wednesday, 12 May 2021 14:15, Arne Schwabe a...@rfc2549.org wr

Re: [Openvpn-devel] Feature request - Allow comments inside markers

2021-05-18 Thread Gert Doering
Hi, On Tue, May 18, 2021 at 02:19:10PM +0200, Arne Schwabe wrote: > We could implement it in the hash parser to skip the lines starting with #. Ah, right. This should be very easy, actually, without affecting anything else that does stuff. Let's see if I can find time :-) gert -- "If was on

[Openvpn-devel] [PATCH v3] Implement --client-crresponse script options and plugin interface

2021-05-18 Thread Arne Schwabe
This is allows scripts and pluginsto parse/react to a CR_RESPONSE message Patch V2: doc fixes, do not put script under ENABLE_PLUGIN Patch V3: rebase Signed-off-by: Arne Schwabe --- doc/man-sections/script-options.rst | 28 - include/openvpn-plugin.h.in | 7 +++- src/openvp

Re: [Openvpn-devel] [PATCH 9/9] Add detailed man page section to setup a OpenVPN setup with peer-fingerprint

2021-05-18 Thread Arne Schwabe
Am 17.05.21 um 19:16 schrieb tincantech: > Hi, > > ‐‐‐ Original Message ‐‐‐ > On Wednesday, 12 May 2021 14:15, Arne Schwabe wrote: > >> This is meant to give new users a quickstart for a useable OpenVPN >> setup. Our own documentation is lacking in this regard and many often >> tutorials

Re: [Openvpn-devel] Feature request - Allow comments inside markers

2021-05-18 Thread Arne Schwabe
Am 17.05.21 um 17:31 schrieb Gert Doering: > Hi, > > On Mon, May 17, 2021 at 02:57:32PM +, tincantech via Openvpn-devel wrote: >> I think it would useful to allow comment inside the >> markers. > > I've run across this as well, and share that sentiment. It would be nice. > > That said, I'

[Openvpn-devel] [PATCH v2] msvc: standalone building

2021-05-18 Thread Lev Stipakov
From: Lev Stipakov This finally enables standalone MSVC building, without dependency on openvpn-build/msvc. This makes MSVC build process much simpler. Dependencies are managed by vcpkg. To install dependencies, run: > vcpkg --overlay-ports=\contrib\vcpkg-ports --overlay-triplets=\c

[Openvpn-devel] [PATCH v2] contrib/vcpkg-ports: add pkcs11-helper port

2021-05-18 Thread Lev Stipakov
From: Lev Stipakov pkcs11-helper is a dependency library used by OpenVPN. So far it has been built only by mingw. Since we're making MSVC build system a first class citizen, we need to build depencencies with MSVC, which we do with vcpkg. All dependencies are in vcpkg official repo, expect pkcs1