Re: [Openvpn-devel] [PATCH v3] Return cached result in tls_authentication_status

2021-05-06 Thread Antonio Quartulli
Hi Arne, after our discussion on IRC I understood you expected this patch to not change the server behaviour. If something is suboptimal, it means it was suboptimal also before this patch. However, with your patch I can clearly see a longer delay in returning the AUTH result to the client, in ca

Re: [Openvpn-devel] [PATCH] Allow PKCS#11 uri to be used as --cert and --key file names

2021-05-06 Thread Selva Nair
Hi, On Thu, May 6, 2021 at 6:12 AM Jan Just Keijser wrote: > > Hi Selva, > > Maybe I'll have to resurrect that idea or require --script-security 2 > > for this? In either case the core code will stay the same -- will wait > > for a review and/or more comments before changing anything. > > > would

[Openvpn-devel] [PATCH v3] Return cached result in tls_authentication_status

2021-05-06 Thread Arne Schwabe
tls_authentication_status does caching to avoid file I/O more than every TLS_MULTI_AUTH_STATUS_INTERVAL (10s) per connection. But counter-intuitively it does not return the cached result but rather TLS_AUTHENTICATION_UNDEFINED if the cache is not refreshed by the call. This is workarounded by forc

Re: [Openvpn-devel] [PATCH] Allow PKCS#11 uri to be used as --cert and --key file names

2021-05-06 Thread Jan Just Keijser
Hi Selva, On 05/05/21 15:29, Selva Nair wrote: On Wed, May 5, 2021 at 4:00 AM Jan Just Keijser wrote: On 05/05/21 07:18, selva.n...@gmail.com wrote: From: Selva Nair If either --cert or --key is specified as a PKCS#11 uri, try to load the certificate and key from any accessible PKCS#11 devi