Re: [Openvpn-devel] [PATCH] Add daemon_pid to --tls-crypt-v2-verify environment

Am 03.05.21 um 19:22 schrieb tincantech via Openvpn-devel: > ‐‐‐ Original Message ‐‐‐ > On Thursday, 29 April 2021 18:15, Richard T Bonhomme > wrote: > >> From: string vest stringves...@gmail.com > >> Under Windows, programmatically retrieving the parent process ID of >> the openvpn ins

Re: [Openvpn-devel] [PATCH] Add daemon_pid to --tls-crypt-v2-verify environment

Hi, On Mon, May 03, 2021 at 05:22:26PM +, tincantech via Openvpn-devel wrote: > Bump. This is auto-deprioritizing review of the patch. We have patchwork to remind us what is open. Submitters that ask multiple times a day about their patch needlessly eat up reviewer brain time, and this is

Re: [Openvpn-devel] [PATCH] Add daemon_pid to --tls-crypt-v2-verify environment

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 ‐‐‐ Original Message ‐‐‐ On Thursday, 29 April 2021 18:15, Richard T Bonhomme wrote: > From: string vest stringves...@gmail.com > > Under Windows, programmatically retrieving the parent process ID of > the openvpn instance which called a s

openvpn-devel@lists.sourceforge.net

Acked-by: Gert Doering Your patch has been applied to the master branch. Release/2.5 has this fix already, as part of commit 3aca477a1b58. Antonio complained about the patch subject:, and asked for a v2 - which I did not see anywhere, so I rewrote the commit subject and now it's out of my work

[Openvpn-devel] [PATCH applied] Re: Fix memory leak in misc unit test

Acked-by: Gert Doering Stare-at-code confirms. "What goes in needs to come out" :-) Your patch has been applied to the master branch. commit 4a35d38efa74becf99ae9c6711f5c10c4b60f84b Author: Arne Schwabe Date: Mon May 3 13:40:43 2021 +0200 Fix memory leak in misc unit test Signed-

[Openvpn-devel] [PATCH applied] Re: Remove support for blocking connect()

Acked-by: Gert Doering Looks good, and buildbots are happy. Your patch has been applied to the master branch. commit 2ec5e1cae681a83992b09b4c6e690b014d4cc340 Author: Arne Schwabe Date: Mon May 3 12:58:50 2021 +0200 Remove support for blocking connect() Signed-off-by: Arne Schwabe

[Openvpn-devel] [PATCH applied] Re: Remove --disable-multihome option

Acked-by: Gert Doering Stared-at, fed to the buildbots, all good. Your patch has been applied to the master branch. commit f17d529c6635eabba61a054b64603b573ad5dbeb Author: Arne Schwabe Date: Mon May 3 12:56:38 2021 +0200 Remove --disable-multihome option Signed-off-by: Arne Schwab

[Openvpn-devel] [PATCH v2 3/7] Return cached result in tls_authentication_status

tls_authentication_status does caching to avoid file I/O more than every TLS_MULTI_AUTH_STATUS_INTERVAL (10s) per connection. But counter-intuitively it does not return the cached result but rather TLS_AUTHENTICATION_UNDEFINED if the cache is not refreshed by the call. This is workarounded by forc

[Openvpn-devel] [PATCH] Fix memory leak in misc unit test

Detected-by: clang -fsanitize=address Signed-off-by: Arne Schwabe --- tests/unit_tests/openvpn/test_misc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit_tests/openvpn/test_misc.c b/tests/unit_tests/openvpn/test_misc.c index 15f6cbff6..c3bea8fc8 100644 --- a/tests/unit_tests/open

[Openvpn-devel] [PATCH v3] Remove support for blocking connect()

It is hard to imagine that we still have any supported OS that does not support non-blocking connect while still supporting non-blocking sockets in general. Patch V2: remove epoll.h removal that should have been in other patch. Patch V3: remove another instance in socket.c that I misseds in v1 Si

[Openvpn-devel] [PATCH v3] Remove --disable-multihome option

With this change we always build multihome support if the operating system supports it. Patch v2: Remove also from config-msvc.h Patch v3: Remove also another line from configure.ac Signed-off-by: Arne Schwabe --- config-msvc.h | 1 - configure.ac | 8 src/openvpn/sysh