Re: [Openvpn-devel] [PATCH] Add daemon_pid to --tls-crypt-v2-verify script environment

2021-04-28 Thread tincantech via Openvpn-devel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Looking closer, I can see that it was damaged in transit .. Please let me know if you would be willing to accept my proposed patch and then I will persist to find a way. If you will not accept the addition then please let me know. Thanks R

Re: [Openvpn-devel] [PATCH] Add daemon_pid to --tls-crypt-v2-verify script environment

2021-04-28 Thread tincantech via Openvpn-devel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Yeah, I forgot to apply and commit -- sorry. I guess I'll send again if this is an acceptable patch and my MTA didn't screw it up ? Please let me know .. thanks ‐‐‐ Original Message ‐‐‐ On Wednesday, 28 April 2021 18:44, tincantech wrot

[Openvpn-devel] [PATCH] Add daemon_pid to --tls-crypt-v2-verify script environment

2021-04-28 Thread tincantech via Openvpn-devel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Openvpn process ID (daemon_pid) provides the most secure way for scripts to verify which process they were called by. This patch adds daemon_poid to --tls-crypt-v2-verify environment. Tested on Linux and Windows. diff --git a/src/openvpn/tls_cryp

[Openvpn-devel] [PATCH applied] Re: Use functions to access key_state instead direct member access

2021-04-28 Thread Gert Doering
Looked a bit at the code, not sure if's really easier to read, or just an "looks unfamiliar" effect. But it works in my tests, not very surprisingly :-) Your patch has been applied to the master branch. commit a80bec331ec65efbbec1adb7892e242589c238ef Author: Arne Schwabe Date: Thu Apr 22 17:17

[Openvpn-devel] [PATCH applied] Re: crypto: respect ECB argument type from prototype

2021-04-28 Thread Gert Doering
Interesting find from gcc11 :-) Your patch has been applied to the master branch. commit 6a3cbb43a3d09dbf0b5df33c741455f34bde2440 Author: Antonio Quartulli Date: Wed Apr 28 10:10:54 2021 +0200 crypto: respect ECB argument type from prototype Signed-off-by: Antonio Quartulli A

[Openvpn-devel] [PATCH applied] Re: Implement deferred auth for scripts

2021-04-28 Thread Gert Doering
Acked-by: Gert Doering I've taken Antonio's ACK on previous versions, plus add my own. v6 differs only minimally from v5 (in the addition of the inotify for the script auth control file), so ACKs and test results of v5 are valid. I have subjected this to the server side cabinet of horrors, with

[Openvpn-devel] [PATCH v2 5/7] Extracting key_state deferred auth status update into function

2021-04-28 Thread Arne Schwabe
This extract the update of a deferred key status into into own function. Patch v2: Do not ignore auth_deferred_expire. Minor format changes. Signed-off-by: Arne Schwabe --- src/openvpn/ssl_verify.c | 91 ++-- 1 file changed, 59 insertions(+), 32 deletions(-)

Re: [Openvpn-devel] [PATCH] crypto: respect ECB argument type from prototype

2021-04-28 Thread Arne Schwabe
Am 28.04.21 um 10:10 schrieb Antonio Quartulli: > From: Antonio Quartulli > > Crypto backends are implementing the cipher_des_encrypt_ecb() > function without fully respecting the type of the argumentis as described > in the function prototype. > > All ECB arguments (key, input block and output

[Openvpn-devel] [PATCH] crypto: respect ECB argument type from prototype

2021-04-28 Thread Antonio Quartulli
From: Antonio Quartulli Crypto backends are implementing the cipher_des_encrypt_ecb() function without fully respecting the type of the argumentis as described in the function prototype. All ECB arguments (key, input block and output block) are expected to be 8 bytes long, for this reason the pr