Hi,
On 27/04/2021 12:21, Arne Schwabe wrote:
>
>>
>>> @@ -369,7 +369,7 @@ bool
>>> send_auth_pending_messages(struct tls_multi *tls_multi, const char *extra,
>>> unsigned int timeout)
>>> {
>>> -struct key_state *ks = &tls_multi->session[TM_ACTIVE].key[KS_PRIMA
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi,
no complaints yet ?
Sent with ProtonMail Secure Email.
ProtonMail, as crap as googlemail.
‐‐‐ Original Message ‐‐‐
On Friday, 23 April 2021 22:16, tincantech via Openvpn-devel
wrote:
> Hi,
>
> I am requesting that daemon_pid be adde
From: Antonio Quartulli
Changes from v4:
- get rid of the overly complex EVENT_SHIFT() macro
Changes from v3:
- re-introduce READ/WRITE_SHIFT because they are different from EVENT_READ/WRITE
- define also EVENT_READ/WRITE using READ/WRITE_SHIFT
Changes from v2:
- moved event definitions to even
Hi,
On Thu, Apr 08, 2021 at 04:02:29PM +0200, Arne Schwabe wrote:
> This patch also refactors the if condition that checks the result of
> the authentication since that has become quite unreadable. It renames
> s1/s2 and extracts some parts of the condition into individual variables
> to make the
Patch has been applied to the master branch.
.. and I still have no test setup for this... "next FOOM!"...
commit 925f0180318033f9ea7885b40b4b8200b35abbca (master)
Author: Gert Doering
Date: Tue Apr 27 13:03:00 2021 +0200
rewrite parse_hash_fingerprint()
Signed-off-by: Gert Doering
Hi,
On 27/04/2021 13:03, Gert Doering wrote:
> The existing code was doing far too much work for too little
> gain - copying the string segment for scanf(), checking extra
> for spaces, making the result quite unreadable.
>
> Verify each segment with (short-circuited) isxdigit() checks,
> then fe
Lightly stared at code and ran client-side tests that actually used
EKM... which meant "upgrading the server the t_client tests talk to"
(and all passes).
Your patch has been applied to the master branch.
commit 9c625f4a6633de05d030884cac779cb41a5060e1
Author: Arne Schwabe
Date: Thu Apr 8 16:02
Looks good to me, and passes regular client side tests :-) - I have
not actually tested the ARIA ciphers, but "they now show up in
--show-cipher mode". Seems I'll need to add this to one of the
server test cases and see what explodes...
WolfSSL folks, please fix the incompatibility Antonio found
The existing code was doing far too much work for too little
gain - copying the string segment for scanf(), checking extra
for spaces, making the result quite unreadable.
Verify each segment with (short-circuited) isxdigit() checks,
then feed directly to scanf(), which will stop parsing on ':'
or
Hi,
On Mon, Apr 26, 2021 at 09:58:38PM +0200, Antonio Quartulli wrote:
> > Rewrite error message to differenciate "hash too short" (including
> differenciate -> differenTiate
fixed.
> > -int i;
> > +int i=0;
>
> spaces around the '='
fixed.
> > -if (strlen(cp) < 2)
> > +
As Antonio says, "just moving around code" (and cleaning up a messy if()
statement - so besides this, it's really trivial to see in diff)
Your patch has been applied to the master branch.
commit 26e40c48b89478cb53d6c2733b346e6dbdc7480b
Author: Arne Schwabe
Date: Thu Apr 22 17:17:18 2021 +0200
>
>> @@ -369,7 +369,7 @@ bool
>> send_auth_pending_messages(struct tls_multi *tls_multi, const char *extra,
>> unsigned int timeout)
>> {
>> -struct key_state *ks = &tls_multi->session[TM_ACTIVE].key[KS_PRIMARY];
>> +struct key_state *ks = get_key_scan(tls_
Hi,
On 22/04/2021 17:17, Arne Schwabe wrote:
> This uses get_key_scan and get_primary key instead the directly
> accessing the members of the struct to improve readiability of
> the code.
>
> Signed-off-by: Arne Schwabe
> ---
> src/openvpn/multi.c | 3 +--
> src/openvpn/push.c | 9
Hi,
On 22/04/2021 17:17, Arne Schwabe wrote:
> tls_pre_encrypt mainly performs the task of selecting the primary
> encryption key but also performs other minor tasks. To allow only
> querying for the key that should be used for encryption extract this
> part of the function into its own function.
14 matches
Mail list logo
