[Openvpn-devel] [PATCH applied] Re: Restore also ping related options on a reconnect

2021-03-23 Thread Gert Doering
The patch is visually fine, and I was actually successfull in testing pre/post behaviour. As in: client with multiple blocks, and using the management interface to make it connect to server A ("push ping, ping-restart") first, then server B ("do not push anything ping-related"). Without the patc

[Openvpn-devel] [PATCH applied] Re: Restore also ping related options on a reconnect

2021-03-23 Thread Gert Doering
The patch is visually fine, and I was actually successfull in testing pre/post behaviour. As in: client with multiple blocks, and using the management interface to make it connect to server A ("push ping, ping-restart") first, then server B ("do not push anything ping-related"). Without the patc

Re: [Openvpn-devel] Visual Studio building for master/2.6 and LZ4

2021-03-23 Thread Samuli Seppänen
Il 22/03/21 11:55, Gert Doering ha scritto: Hi, (I have changed the Subject: line to make clear that this is a bigger topic now) On Mon, Mar 22, 2021 at 11:51:46AM +0200, Lev Stipakov wrote: For 2.6, I think we should drop openvpn-build for Windows (VS) building and switch to vcpkg for depende

[Openvpn-devel] [PATCH applied] Re: Move NCP saving and restore to the prepush restore code

2021-03-23 Thread Gert Doering
Your patch has been applied to the master branch. As discussed with Antonion on IRC, we have no real testbed to test this code change ("connect to server A that pushes options, disconnect, then connect to server B that *does not* push anything"). I did some manual tests with - a client config t

[Openvpn-devel] [PATCH applied] Re: Move restoring pre pull options to initialising of c2 context

2021-03-23 Thread Gert Doering
Your patch has been applied to the master branch. I do not really have a test rig to test this, currently. I think it would need a long-running client instance that connects to a server, receives a set of options, disconnects (server kicking it out?), reconnects, and receives *different* options.