Re: [Openvpn-devel] [PATCH] Ignore --cipher for cipher negotiation in server client mode

2021-03-04 Thread Arne Schwabe
> > Ignoring --cipher in a future release will have quite a higher > probability of breaking existing configurations.  Now, this is set in > context of --data-ciphers, which is very different code wise.  But the > code for --ciphers is essentially the same as --data-ciphers-fallback. It is not th

[Openvpn-devel] [PATCH v2] Cleanup print_details and add signature/ED certificate print

2021-03-04 Thread Arne Schwabe
This commit cleans up the logic in the function a bit. It also makes it more clear the the details printed in the second part of the message are details about the peer certificate and not the TLS connection as such. Also print the signature algorithm as this might help to identify peer certificate

Re: [Openvpn-devel] [PATCH] Ignore --cipher for cipher negotiation in server client mode

2021-03-04 Thread David Sommerseth
On 07/09/2020 18:18, Arne Schwabe wrote: OpenVPN will ignore --cipher in lieu of the replacement data-ciphers for cipher negioation. Signed-off-by: Arne Schwabe --- doc/man-sections/protocol-options.rst | 6 -- src/openvpn/options.c | 26 -- 2 fi

Re: [Openvpn-devel] [PATCH] Cleanup print_details and add signature/ED certificate print

2021-03-04 Thread David Sommerseth
On 07/09/2020 18:02, Arne Schwabe wrote: This commit cleans up the logic in the function a bit. It also makes it more clear the the details printed in the second part of the message are details about the peer certificate and not the TLS connection as such. Also print the signature algorithm as th

Re: [Openvpn-devel] [PATCH v3] Add example script demonstrating TOTP via auth-pending

2021-03-04 Thread David Sommerseth
On 04/03/2021 12:40, Arne Schwabe wrote: Signed-off-by: Arne Schwabe Patch v3: Some minor cleanups in the script (rename CNs, add more comments) Signed-off-by: Arne Schwabe --- doc/man-sections/script-options.rst | 3 + sample/sample-scripts/totpauth.py | 111 ++

Re: [Openvpn-devel] [PATCH v4] Implement deferred auth for scripts

2021-03-04 Thread David Sommerseth
On 04/03/2021 12:40, Arne Schwabe wrote: This patch also refactors the if condition that checks the result of the authentication since that has become quite unreadable. It renames s1/s2 and extracts some parts of the condition into individual variables to make the condition better understandle P

[Openvpn-devel] [PATCH v4] Implement deferred auth for scripts

2021-03-04 Thread Arne Schwabe
This patch also refactors the if condition that checks the result of the authentication since that has become quite unreadable. It renames s1/s2 and extracts some parts of the condition into individual variables to make the condition better understandle Patch v2: add refactoring of the if conditio

[Openvpn-devel] [PATCH v3] Add example script demonstrating TOTP via auth-pending

2021-03-04 Thread Arne Schwabe
Signed-off-by: Arne Schwabe Patch v3: Some minor cleanups in the script (rename CNs, add more comments) Signed-off-by: Arne Schwabe --- doc/man-sections/script-options.rst | 3 + sample/sample-scripts/totpauth.py | 111 2 files changed, 114 insertions(+) creat

Re: [Openvpn-devel] Segmentation fault in OpenVPN 2.6_git [git:dco/fcc852a9b2ea832c]

2021-03-04 Thread Gert Doering
Hi, On Thu, Mar 04, 2021 at 05:10:19PM +0800, Tony He wrote: > I used static key and saw same error. Seems static key is broken in this test branch. This is not a recommended way to run OpenVPN, so it's not always fully tested in development branches (we *do* have tests for it in the official tr

Re: [Openvpn-devel] Segmentation fault in OpenVPN 2.6_git [git:dco/fcc852a9b2ea832c]

2021-03-04 Thread Tony He
Antonio Quartulli 于2021年3月4日周四 下午3:48写道: > Hi Tony, > > On 04/03/2021 03:10, Tony He wrote: > > > > Arne Schwabe mailto:a...@rfc2549.org>> 于2021年3月3日 > > 周三 下午7:56写道: > > > > Am 03.03.21 um 08:46 schrieb Tony He: > > > Hi Arne, > > > > > > I encountered segmentation fault in your