Re: [Openvpn-devel] [PATCH applied] Re: Speedup TCP remote hosts connections

2020-10-05 Thread Vladislav Grishenko
Hi Gert, > "--tcp-server" Yep, mean it, even poll doesn't used there. Have no any prio about it tho, just related thoughts. -- Best Regards, Vladislav Grishenko > -Original Message- > From: Gert Doering > Sent: Monday, October 5, 2020 10:28 PM > To: Vladislav Grishenko > Cc: 'Gert Doer

Re: [Openvpn-devel] [PATCH applied] Re: Speedup TCP remote hosts connections

2020-10-05 Thread Gert Doering
Hi, On Mon, Oct 05, 2020 at 10:22:43PM +0500, Vladislav Grishenko wrote: > Perhaps same approach can be applied to server's tcp listening, would > require testing of more management cases. There's two code paths here --tcp-server and --mode server + --tcp I think the "mode server" code path

Re: [Openvpn-devel] [PATCH applied] Re: Speedup TCP remote hosts connections

2020-10-05 Thread Vladislav Grishenko
Hi Gert, Thanks for that. Perhaps same approach can be applied to server's tcp listening, would require testing of more management cases. -- Best Regards, Vladislav Grishenko > -Original Message- > From: Gert Doering > Sent: Sunday, October 4, 2020 5:19 PM > To: Vladislav Grishenko > C

Re: [Openvpn-devel] [PATCH applied] Re: Support X509 field list to be username

2020-10-05 Thread Vladislav Grishenko
Hi Gert, Thank you. -- Best Regards, Vladislav Grishenko > -Original Message- > From: Gert Doering > Sent: Monday, October 5, 2020 3:36 PM > To: Vladislav Grishenko > Cc: openvpn-devel@lists.sourceforge.net > Subject: [PATCH applied] Re: Support X509 field list to be username > > Your

[Openvpn-devel] [PATCH] Add function for common env setting of verify user/pass calls

2020-10-05 Thread Arne Schwabe
This removes the code duplication in verify_user_pass_script, verify_user_pass_plugin and verify_user_pass_management. In most of these function it also removes a This also fixes a bug that username is not set if auth-gen-token is used without the external-auth flag as without calling any externa

[Openvpn-devel] [PATCH applied] Re: Support X509 field list to be username

2020-10-05 Thread Gert Doering
Your patch has been applied to the master branch. Client-side tested, and lightly stared at the code. The whitespace dragon made me add that blank after comma (but not the other one in code not already touched by this patch) - IRC discussion points to "sp_after_comma", which we indeed do not set

Re: [Openvpn-devel] [PATCH v5] Support X509 field list to be username

2020-10-05 Thread Vladislav Grishenko
Hi Arne, > From: Arne Schwabe > Sent: Monday, October 5, 2020 1:26 PM > Am 05.10.20 um 02:51 schrieb Vladislav Grishenko: > > OpenVPN has the ability to choose different X509 field in case "CN" > > can not be use used to be unique connected username since commit > > 935c62be9c0c8a256112df818bfb847

[Openvpn-devel] [PATCH] Ignore deprecation warning for daemon on macOS

2020-10-05 Thread Arne Schwabe
macOS warns that we should posix_spawn instead. However posix_spawn would require a major redesign of code to daemonise or drop the --daemon feature on macOS. Ignore the clang warning in order to allow -Werror compile on macOS. Signed-off-by: Arne Schwabe --- src/openvpn/init.c|

Re: [Openvpn-devel] [PATCH v5] Support X509 field list to be username

2020-10-05 Thread Arne Schwabe
Am 05.10.20 um 02:51 schrieb Vladislav Grishenko: > OpenVPN has the ability to choose different X509 field in case "CN" can > not be use used to be unique connected username since commit > 935c62be9c0c8a256112df818bfb8470586a23b6 "Choose a different field in > X509 to be username". > Unfortunately