[Openvpn-devel] [PATCH] Fix update_time() and openvpn_gettimeofday()

2020-09-21 Thread Vladislav Grishenko
With TIME_BACKTRACK_PROTECTION defined, openvpn_gettimeofday() uses and updates global variable "now_usec" along with "now" only if current time is ahead of the previsouly stored, taking nanoseconds into account. But, update_time() function updates only "now" leaving "now_usec" as is with any previ

Re: [Openvpn-devel] [PATCH] Fix line number reporting on config file errors after segments

2020-09-21 Thread Antonio Quartulli
Hi, On 21/09/2020 09:50, Gert Doering wrote: > Hi, > > On Mon, Sep 21, 2020 at 09:22:38AM +0200, Antonio Quartulli wrote: >> Sorry for not chiming in earlier, but honestly I believe your other >> option would be "cleaner". The other option being "return int instead of >> bool, where the returned

[Openvpn-devel] [PATCH v2] Allow 'none' cipher being specified in --data-ciphers

2020-09-21 Thread Arne Schwabe
Although we want to get rid of none as cipher, we still have not deprecated it. In order to use it currently you need --ncp-disable together with --cipher none to use the none cipher. In our current situation allowing none to be specified in data-ciphers is the lesser evil. This commit also fixes

[Openvpn-devel] [PATCH] Allow 'none' cipher being specified in --data-ciphers

2020-09-21 Thread Arne Schwabe
Although we want to get rid of none as cipher, we still have not deprecated it. In order to use it currently you need --ncp-disable together with --cipher none to use the none cipher. In our current situation allowing none to be specified in data-ciphers is the lesser evil. This commit also fixes

Re: [Openvpn-devel] [PATCH] Fix line number reporting on config file errors after segments

2020-09-21 Thread Gert Doering
Hi, On Mon, Sep 21, 2020 at 09:22:38AM +0200, Antonio Quartulli wrote: > Sorry for not chiming in earlier, but honestly I believe your other > option would be "cleaner". The other option being "return int instead of > bool, where the returned value is the number of lines of the inline'd > material

Re: [Openvpn-devel] [PATCH] Fix line number reporting on config file errors after segments

2020-09-21 Thread Antonio Quartulli
Hi, On 20/09/2020 11:09, Gert Doering wrote: > segments neglected to increment the "current line number > in config file" variable (line_num), so after the first , > errors reported have the wrong line number. > > Fix by introducing an extra argument to the check_inline*() / > read_inline_file()