Re: [Openvpn-devel] [PATCH v3 2/2] Document different behaviour of dynamic cipher negotiation

2020-08-09 Thread tincanteksup
spelling/grammar and some questions ... On 09/08/2020 15:19, Arne Schwabe wrote: This adds a section in the man page that details the various behaviour of older client/servers when using OpenVPN 2.5. Signed-off-by: Arne Schwabe --- Changes.rst | 23 +++ doc/

Re: [Openvpn-devel] [PATCH v3 1/2] Rework NCP compability logic and drop BF-CBC support by default

2020-08-09 Thread Arne Schwabe
Am 09.08.20 um 18:14 schrieb tincanteksup: >> +  If no common cipher is found during cipher negotiation, the  >> connection >> +  is terminated. To support old clients/server that do not provide >> any cipher > > clients > (remove /server ..  I think this is what was meant?) No, old clients/serve

Re: [Openvpn-devel] [PATCH v3 1/2] Rework NCP compability logic and drop BF-CBC support by default

2020-08-09 Thread tincanteksup
spelling/grammar Couple of typos and some suggested grammar improvements. On 09/08/2020 15:19, Arne Schwabe wrote: This reworks the NCP logic to be more strict about what is considered an acceptable result of an NCP negotiation. It also us to finally drop BF-CBC support by default. It is also

[Openvpn-devel] [PATCH v3 1/2] Rework NCP compability logic and drop BF-CBC support by default

2020-08-09 Thread Arne Schwabe
This reworks the NCP logic to be more strict about what is considered an acceptable result of an NCP negotiation. It also us to finally drop BF-CBC support by default. All new behaviour is currently limited to server/client mode with pull enabled. P2p mode without pull does not change. New Server

[Openvpn-devel] [PATCH v3 2/2] Document different behaviour of dynamic cipher negotiation

2020-08-09 Thread Arne Schwabe
This adds a section in the man page that details the various behaviour of older client/servers when using OpenVPN 2.5. Signed-off-by: Arne Schwabe --- Changes.rst | 23 +++ doc/man-sections/cipher-negotiation.rst | 87 + doc/openvpn.8.rst

Re: [Openvpn-devel] [PATCH v2] Rework NCP compability logic and drop BF-CBC support by default

2020-08-09 Thread Gert Doering
Hi, On Sat, Aug 08, 2020 at 08:11:13PM +0200, Arne Schwabe wrote: > > Not sure how to tackle the "ccd/ push cipher is broken now with 2.4-NCP > > clients" part. I think this is useful functionality, but the current > > patch does not allow this "unless the client is already using the to-be- > > p