[Openvpn-devel] [PATCH applied] Re: client-connect: Add deferred support to the client-connect script handler

2020-07-19 Thread Gert Doering
Acked-by: Gert Doering Tested on the server rig, with a client-connect script which can do deferred ("echo 2 >$client_connect_deferred_file") if requested, and will then succeed, fail, or "disable". For "succeed" and "disable", this is all clear from the server logs, but for "fail", you see the

Re: [Openvpn-devel] [PATCH v8 2/5] client-connect: Add deferred support to the client-connect script handler

2020-07-19 Thread tincanteksup
4x typo On 19/07/2020 18:34, Arne Schwabe wrote: From: Fabian Knittel This patch introduces the concept of a return value file for the client-connect handlers. (This is very similar to the auth value file used during deferred authentication.) The file name is stored in the client_connect_stat

Re: [Openvpn-devel] [PATCH] Convert cc_check_return to switch/case

2020-07-19 Thread Gert Doering
Hi, On Fri, Jul 17, 2020 at 02:06:02PM +0200, David Sommerseth wrote: > On 17/07/2020 13:29, Arne Schwabe wrote: > > The return false/return true is the result of > > running uncrustify. [..] > > +case CC_RET_SKIPPED: return true; > > + > > +default: ASSERT(0); > > Code style poli

[Openvpn-devel] [PATCH applied] Re: Remove CAS_PARTIAL state

2020-07-19 Thread Gert Doering
Acked-by: Gert Doering Reviewed, change makes sense. Even better, it makes my torture test setup (client-connect script, client-connect plugin, client-connect-v2 plugin) which can inject arbitrary "FAIL" or "disable" at any of these points work as requested - while not breaking other tests. T

[Openvpn-devel] [PATCH v8 4/5] client-connect: Add deferred support to the client-connect plugin v1 handler

2020-07-19 Thread Arne Schwabe
From: Fabian Knittel Uses the infrastructure provided and used in the previous patch to provide deferral support to the v1 client-connect plugin handler as well. Signed-off-by: Fabian Knittel PATCH V3: Modify the API to also (optionally) call the plugin on a deferred call. This allows the plug

[Openvpn-devel] [PATCH v8 3/5] client-connect: Use inotify for the deferred client-connect status file

2020-07-19 Thread Arne Schwabe
As we never do client-connect and authentication at the same time it is safe to reuse the existing fields for client-connect return status file Signed-off-by: Arne Schwabe --- src/openvpn/multi.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/openvpn/mu

[Openvpn-devel] [PATCH v8 1/5] Remove CAS_PARTIAL state

2020-07-19 Thread Arne Schwabe
This state is used to handle a corner case when multiple connect handlers are active and one of them fails. Unfortunately, this state complicates the state machine a bit without a good benefit. Current behaviour: First/all connect handler(s) fail: - client disconnect handler is not called at a

[Openvpn-devel] [PATCH v8 2/5] client-connect: Add deferred support to the client-connect script handler

2020-07-19 Thread Arne Schwabe
From: Fabian Knittel This patch introduces the concept of a return value file for the client-connect handlers. (This is very similar to the auth value file used during deferred authentication.) The file name is stored in the client_connect_state struct. In addition, the patch also allows the st

[Openvpn-devel] [PATCH v8 5/5] client-connect: Implement deferred connect support for plugin API v2

2020-07-19 Thread Arne Schwabe
The V2 API is simpler than the V1 API since there is no passing of data via files. This also means that with the current API the V2 API cannot support async notify via files. Adding a file just for async notify seems very hacky and when needed we should implement a better option when async is neede

Re: [Openvpn-devel] [Openvpn-users] Join PC with OpenVpn to Active Directory

2020-07-19 Thread Selva Nair
Hi, If your VPN establishes a route to the domain controller(s) and the domain name resolves from the client, you can join the domain just as you would do while directly connected to the LAN. For example, if the domain name is example.local, "nslookup example.local" should return the IP addresses

[Openvpn-devel] [PATCH applied] Re: doc/man: Do not install man CONTRIBUTING.rst Changes.rst files

2020-07-19 Thread Gert Doering
Acked-by: Gert Doering Your patch has been applied to the master branch. commit 4cabd28a77116ab3926f81258af9bdb342e0336a Author: David Sommerseth Date: Sun Jul 19 13:48:53 2020 +0200 doc/man: Do not install man CONTRIBUTING.rst Changes.rst files Signed-off-by: David Sommerseth

[Openvpn-devel] [PATCH] doc/man: Do not install man *.rst files

2020-07-19 Thread David Sommerseth
When the man page got split up into several .rst files, these files got listed into dist_doc_DATA=. This variable will both distribute (package in the source tarball) and install these files into /usr/share/doc. This was not intended, and it duplicates the content and makes the doc dir quite messy