[Openvpn-devel] [PATCH v2 5/8] doc/man: Mark compression options as deprecated

2020-07-16 Thread David Sommerseth
Due to the VORACLE attack vector, compression in general is deprecated. Make this clear in the man page. Also remove an incorrect statement claiming --compress lzo is compatible with --comp-lzo. It is not, as --compress lzo uses a different compression framing than --comp-lzo. Signed-off-by: Dav

[Openvpn-devel] [PATCH v2 7/8] doc/man: Update --txqueuelen default setting (Now OS default)

2020-07-16 Thread David Sommerseth
From: Richard Bonhomme Signed-off-by: Richard Bonhomme Signed-off-by: David Sommerseth --- doc/man-sections/advanced-options.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/man-sections/advanced-options.rst b/doc/man-sections/advanced-options.rst index dbf7799c..9b

[Openvpn-devel] [PATCH v2 6/8] doc/man: Adopt compression documentation

2020-07-16 Thread David Sommerseth
Commit c67e93b25208be2 updated the man page in reagrds to new compression options and improving existing compression options. This adopts those changes into the .rst format. Signed-off-by: David Sommerseth --- doc/man-sections/protocol-options.rst | 52 ++- 1 file change

[Openvpn-devel] [PATCH v2 8/8] doc/man: Documentation for --bind-dev / VRFs on Linux

2020-07-16 Thread David Sommerseth
Signed-off-by: Maximilian Wilhelm Signed-off-by: David Sommerseth --- doc/man-sections/network-config.rst | 1 + .../virtual-routing-and-forwarding.rst| 78 +++ doc/man-sections/vpn-network-options.rst | 4 + 3 files changed, 83 insertions(+) create mode

[Openvpn-devel] [PATCH v2 0/8] man-page overhaul project - round 2

2020-07-16 Thread David Sommerseth
Hi, In the community meeting 2020-07-16, it was agreed to try to squash several commits and reduce the number of patches. In addition to split up the biggest patch into two parts to try to sneak everything into the mailing list without sending too large patches. I've kept a few changes separate,

Re: [Openvpn-devel] [PATCH v5 14/14] client-connect: Add documentation for the deferred client connect feature

2020-07-16 Thread David Sommerseth
On 16/07/2020 23:07, Gert Doering wrote: > Hi, > > On Thu, Jul 16, 2020 at 11:04:09PM +0200, David Sommerseth wrote: >> So I'm looking into migrating this text over to the new .rst format ... and I >> have a question ... > > This one *should* be identical to 6/6 from the "v7" series, but just for

Re: [Openvpn-devel] [PATCH v5 14/14] client-connect: Add documentation for the deferred client connect feature

2020-07-16 Thread Gert Doering
Hi, On Thu, Jul 16, 2020 at 11:04:09PM +0200, David Sommerseth wrote: > So I'm looking into migrating this text over to the new .rst format ... and I > have a question ... This one *should* be identical to 6/6 from the "v7" series, but just for completeness - the "v5" series has been reworked com

Re: [Openvpn-devel] [PATCH v5 14/14] client-connect: Add documentation for the deferred client connect feature

2020-07-16 Thread David Sommerseth
So I'm looking into migrating this text over to the new .rst format ... and I have a question ... On 11/07/2020 11:36, Arne Schwabe wrote: > diff --git a/doc/openvpn.8 b/doc/openvpn.8 > index 03ae5ac5..7a0080bf 100644 > --- a/doc/openvpn.8 > +++ b/doc/openvpn.8 > @@ -3422,6 +3422,13 @@ is signifi

Re: [Openvpn-devel] [PATCH v7 5/6] client-connect: Implement deferred connect support for plugin API v2

2020-07-16 Thread Gert Doering
Hi, On Thu, Jul 16, 2020 at 03:43:14PM +0200, Arne Schwabe wrote: > The V2 API is simpler than the V1 API since there is no passing of > data via files. This also means that with the current API the V2 API > cannot support async notify via files. Adding a file just for async > notify seems very ha

Re: [Openvpn-devel] [PATCH v7 4/6] client-connect: Add deferred support to the client-connect plugin v1 handler

2020-07-16 Thread Gert Doering
Hi, On Thu, Jul 16, 2020 at 03:43:13PM +0200, Arne Schwabe wrote: > From: Fabian Knittel > > Uses the infrastructure provided and used in the previous patch to provide > deferral support to the v1 client-connect plugin handler as well. start client jobs... 22... Test sets succeeded: 1 2 3 4 6 8

[Openvpn-devel] summary of the community discussion on 2020-07-16

2020-07-16 Thread Gert Doering
Hi, since Samuli is still hiding somewhere on a beach, it's my pleasure to serve as a stand-in and bring you today's minutes... Summary: - man page integration: patch set on the list, cron2 will skim-and-merge tomorrow'ish - list of deprecated options in the wiki: we have patches for OpenSS

Re: [Openvpn-devel] [PATCH 12/16] doc/man: Misc grammar and typo fixes

2020-07-16 Thread tincanteksup
Hi, I recognise all these changes as my own. Even so, I do not understand why these two variant are present: EG: + entry is tried. Specifying ``n`` as :code:`1` would try See --connect-retry-max here: https://gitlab.com/dazo/openvpn/-/blob/dev/man-reformatting/doc/man-sections/client-opt

[Openvpn-devel] [PATCH applied] Re: client-connect: Refactor client-connect handling to calling a bunch of hooks in a loop

2020-07-16 Thread Gert Doering
Your patch has been applied to the master branch. I have *not* reformatted the multi_client_connect_handler block - this is stuff that goes away in 08/14 again, so reformatting now is doubly futile. (Speaking of patch granularity: the combination of 05+06+08 is causing three times work for some

Re: [Openvpn-devel] [PATCH v7 3/6] client-connect: Use inotify for the deferred client-connect status file

2020-07-16 Thread Gert Doering
Hi, On Thu, Jul 16, 2020 at 03:43:12PM +0200, Arne Schwabe wrote: > As we never do client-connect and authentication at the same time > it is safe to reuse the existing fields for client-connect return > status file I don't have anything with inotify prepared right now, so I can't really test thi

Re: [Openvpn-devel] [PATCH v7 2/6] client-connect: Add deferred support to the client-connect script handler

2020-07-16 Thread Gert Doering
Hi, On Thu, Jul 16, 2020 at 03:43:11PM +0200, Arne Schwabe wrote: > From: Fabian Knittel > > This patch introduces the concept of a return value file for the > client-connect > handlers. (This is very similar to the auth value file used during deferred > authentication.) The file name is store

Re: [Openvpn-devel] [PATCH v7 1/6] client-connect: Add CC_RET_DEFERRED and cope with deferred client-connect

2020-07-16 Thread Antonio Quartulli
Hi, On 16/07/2020 15:43, Arne Schwabe wrote: > This patch moves the state, that was previously tracked within the > multi_connection_established() function, into struct client_connect_state. > The > multi_connection_established() function can now be exited and re-entered as > many times as neces

Re: [Openvpn-devel] [PATCH v7 1/6] client-connect: Add CC_RET_DEFERRED and cope with deferred client-connect

2020-07-16 Thread Gert Doering
Hi, On Thu, Jul 16, 2020 at 03:43:10PM +0200, Arne Schwabe wrote: > This patch moves the state, that was previously tracked within the > multi_connection_established() function, into struct client_connect_state. > The > multi_connection_established() function can now be exited and re-entered as

[Openvpn-devel] [PATCH v7 5/6] client-connect: Implement deferred connect support for plugin API v2

2020-07-16 Thread Arne Schwabe
The V2 API is simpler than the V1 API since there is no passing of data via files. This also means that with the current API the V2 API cannot support async notify via files. Adding a file just for async notify seems very hacky and when needed we should implement a better option when async is neede

[Openvpn-devel] [PATCH v7 4/6] client-connect: Add deferred support to the client-connect plugin v1 handler

2020-07-16 Thread Arne Schwabe
From: Fabian Knittel Uses the infrastructure provided and used in the previous patch to provide deferral support to the v1 client-connect plugin handler as well. Signed-off-by: Fabian Knittel PATCH V3: Modify the API to also (optionally) call the plugin on a deferred call. This allows the plug

[Openvpn-devel] [PATCH v7 2/6] client-connect: Add deferred support to the client-connect script handler

2020-07-16 Thread Arne Schwabe
From: Fabian Knittel This patch introduces the concept of a return value file for the client-connect handlers. (This is very similar to the auth value file used during deferred authentication.) The file name is stored in the client_connect_state struct. In addition, the patch also allows the st

[Openvpn-devel] [PATCH v7 6/6] client-connect: Add documentation for the deferred client connect feature

2020-07-16 Thread Arne Schwabe
Patch V5: Fix typos, clarify man page section about deferred client-connect script. Add section to Changes.rst Signed-off-by: Arne Schwabe --- Changes.rst | 4 +++ doc/openvpn.8 | 55 +++-- include/openvpn-plugin.h.in | 21

[Openvpn-devel] [PATCH v7 3/6] client-connect: Use inotify for the deferred client-connect status file

2020-07-16 Thread Arne Schwabe
As we never do client-connect and authentication at the same time it is safe to reuse the existing fields for client-connect return status file Signed-off-by: Arne Schwabe --- src/openvpn/multi.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/openvpn/mu

[Openvpn-devel] [PATCH v7 1/6] client-connect: Add CC_RET_DEFERRED and cope with deferred client-connect

2020-07-16 Thread Arne Schwabe
This patch moves the state, that was previously tracked within the multi_connection_established() function, into struct client_connect_state. The multi_connection_established() function can now be exited and re-entered as many times as necessary - without losing the client-connect handling state.